Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_vpc_endpoint: Correct the ARN account id #17782

Merged
merged 2 commits into from
Mar 17, 2021
Merged

aws_vpc_endpoint: Correct the ARN account id #17782

merged 2 commits into from
Mar 17, 2021

Conversation

shuheiktgw
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16978

Output from acceptance testing:

$  make testacc TESTARGS='-run=TestAccAWSVpcEndpoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcEndpoint_ -timeout 120m
=== RUN   TestAccAWSVpcEndpoint_gatewayBasic
=== PAUSE TestAccAWSVpcEndpoint_gatewayBasic
=== RUN   TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccAWSVpcEndpoint_gatewayPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayPolicy
=== RUN   TestAccAWSVpcEndpoint_interfaceBasic
=== PAUSE TestAccAWSVpcEndpoint_interfaceBasic
=== RUN   TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccAWSVpcEndpoint_disappears
=== PAUSE TestAccAWSVpcEndpoint_disappears
=== RUN   TestAccAWSVpcEndpoint_tags
=== PAUSE TestAccAWSVpcEndpoint_tags
=== RUN   TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== PAUSE TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== CONT  TestAccAWSVpcEndpoint_gatewayBasic
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== CONT  TestAccAWSVpcEndpoint_disappears
=== CONT  TestAccAWSVpcEndpoint_tags
=== CONT  TestAccAWSVpcEndpoint_interfaceBasic
=== CONT  TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== CONT  TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== CONT  TestAccAWSVpcEndpoint_gatewayPolicy
=== CONT  TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
--- PASS: TestAccAWSVpcEndpoint_disappears (63.21s)
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (69.60s)
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (109.79s)
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy (116.83s)
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (137.92s)
--- PASS: TestAccAWSVpcEndpoint_tags (138.56s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate (262.77s)
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (430.43s)
--- PASS: TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer (443.34s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate (479.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	481.158s

$ make testacc TESTARGS='-run=TestAccDataSourceAwsVpcEndpoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsVpcEndpoint_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpcEndpoint_gatewayBasic
=== PAUSE TestAccDataSourceAwsVpcEndpoint_gatewayBasic
=== RUN   TestAccDataSourceAwsVpcEndpoint_byId
=== PAUSE TestAccDataSourceAwsVpcEndpoint_byId
=== RUN   TestAccDataSourceAwsVpcEndpoint_byFilter
=== PAUSE TestAccDataSourceAwsVpcEndpoint_byFilter
=== RUN   TestAccDataSourceAwsVpcEndpoint_byTags
=== PAUSE TestAccDataSourceAwsVpcEndpoint_byTags
=== RUN   TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags
=== PAUSE TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags
=== RUN   TestAccDataSourceAwsVpcEndpoint_interface
=== PAUSE TestAccDataSourceAwsVpcEndpoint_interface
=== CONT  TestAccDataSourceAwsVpcEndpoint_gatewayBasic
=== CONT  TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags
=== CONT  TestAccDataSourceAwsVpcEndpoint_interface
=== CONT  TestAccDataSourceAwsVpcEndpoint_byFilter
=== CONT  TestAccDataSourceAwsVpcEndpoint_byId
=== CONT  TestAccDataSourceAwsVpcEndpoint_byTags
--- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayBasic (59.30s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_byTags (59.32s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_byId (59.41s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_byFilter (59.86s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags (65.59s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_interface (194.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	196.836s

Thank you for your review!

@shuheiktgw shuheiktgw requested a review from a team as a code owner February 23, 2021 22:46
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 23, 2021
@shuheiktgw shuheiktgw mentioned this pull request Feb 23, 2021
Closed
12 tasks
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 23, 2021
@ewbankkit
Copy link
Contributor

@shuheiktgw Thanks for the contribution.
Could you please also update this documentation in website/docs/index.html.markdown to remove the affected resources and data sources.

@ghost ghost added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Feb 24, 2021
ewbankkit
ewbankkit reviewed Feb 25, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ ACCTEST_PARALLELISM=2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpoint_\|TestAccDataSourceAwsVpcEndpoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpoint_\|TestAccDataSourceAwsVpcEndpoint_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpcEndpoint_gatewayBasic
=== PAUSE TestAccDataSourceAwsVpcEndpoint_gatewayBasic
=== RUN   TestAccDataSourceAwsVpcEndpoint_byId
=== PAUSE TestAccDataSourceAwsVpcEndpoint_byId
=== RUN   TestAccDataSourceAwsVpcEndpoint_byFilter
=== PAUSE TestAccDataSourceAwsVpcEndpoint_byFilter
=== RUN   TestAccDataSourceAwsVpcEndpoint_byTags
=== PAUSE TestAccDataSourceAwsVpcEndpoint_byTags
=== RUN   TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags
=== PAUSE TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags
=== RUN   TestAccDataSourceAwsVpcEndpoint_interface
=== PAUSE TestAccDataSourceAwsVpcEndpoint_interface
=== RUN   TestAccAWSVpcEndpoint_gatewayBasic
=== PAUSE TestAccAWSVpcEndpoint_gatewayBasic
=== RUN   TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccAWSVpcEndpoint_gatewayPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayPolicy
=== RUN   TestAccAWSVpcEndpoint_interfaceBasic
=== PAUSE TestAccAWSVpcEndpoint_interfaceBasic
=== RUN   TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccAWSVpcEndpoint_disappears
=== PAUSE TestAccAWSVpcEndpoint_disappears
=== RUN   TestAccAWSVpcEndpoint_tags
=== PAUSE TestAccAWSVpcEndpoint_tags
=== RUN   TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== PAUSE TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== CONT  TestAccDataSourceAwsVpcEndpoint_gatewayBasic
=== CONT  TestAccAWSVpcEndpoint_gatewayBasic
--- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayBasic (34.65s)
=== CONT  TestAccAWSVpcEndpoint_interfaceBasic
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (36.17s)
=== CONT  TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (139.17s)
=== CONT  TestAccAWSVpcEndpoint_tags
--- PASS: TestAccAWSVpcEndpoint_tags (85.30s)
=== CONT  TestAccAWSVpcEndpoint_disappears
--- PASS: TestAccAWSVpcEndpoint_disappears (31.11s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
--- PASS: TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer (273.71s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate (261.92s)
=== CONT  TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate (271.26s)
=== CONT  TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags
--- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags (35.66s)
=== CONT  TestAccAWSVpcEndpoint_gatewayPolicy
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (57.47s)
=== CONT  TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy (66.41s)
=== CONT  TestAccDataSourceAwsVpcEndpoint_interface
--- PASS: TestAccDataSourceAwsVpcEndpoint_interface (184.50s)
=== CONT  TestAccDataSourceAwsVpcEndpoint_byFilter
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (395.41s)
=== CONT  TestAccDataSourceAwsVpcEndpoint_byTags
--- PASS: TestAccDataSourceAwsVpcEndpoint_byFilter (33.42s)
=== CONT  TestAccDataSourceAwsVpcEndpoint_byId
--- PASS: TestAccDataSourceAwsVpcEndpoint_byTags (32.43s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_byId (33.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	992.118s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @

Verified Acceptance Tests in Commercial (us-west-2)

ACCTEST_PARALLELISM=2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpoint_\|TestAccDataSourceAwsVpcEndpoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpoint_\|TestAccDataSourceAwsVpcEndpoint_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpcEndpoint_gatewayBasic
=== PAUSE TestAccDataSourceAwsVpcEndpoint_gatewayBasic
=== RUN   TestAccDataSourceAwsVpcEndpoint_byId
=== PAUSE TestAccDataSourceAwsVpcEndpoint_byId
=== RUN   TestAccDataSourceAwsVpcEndpoint_byFilter
=== PAUSE TestAccDataSourceAwsVpcEndpoint_byFilter
=== RUN   TestAccDataSourceAwsVpcEndpoint_byTags
=== PAUSE TestAccDataSourceAwsVpcEndpoint_byTags
=== RUN   TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags
=== PAUSE TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags
=== RUN   TestAccDataSourceAwsVpcEndpoint_interface
=== PAUSE TestAccDataSourceAwsVpcEndpoint_interface
=== RUN   TestAccAWSVpcEndpoint_gatewayBasic
=== PAUSE TestAccAWSVpcEndpoint_gatewayBasic
=== RUN   TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccAWSVpcEndpoint_gatewayPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayPolicy
=== RUN   TestAccAWSVpcEndpoint_interfaceBasic
=== PAUSE TestAccAWSVpcEndpoint_interfaceBasic
=== RUN   TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccAWSVpcEndpoint_disappears
=== PAUSE TestAccAWSVpcEndpoint_disappears
=== RUN   TestAccAWSVpcEndpoint_tags
=== PAUSE TestAccAWSVpcEndpoint_tags
=== RUN   TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== PAUSE TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== CONT  TestAccDataSourceAwsVpcEndpoint_gatewayBasic
=== CONT  TestAccAWSVpcEndpoint_interfaceBasic
--- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayBasic (28.36s)
=== CONT  TestAccAWSVpcEndpoint_disappears
--- PASS: TestAccAWSVpcEndpoint_disappears (27.04s)
=== CONT  TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (112.89s)
=== CONT  TestAccAWSVpcEndpoint_tags
=== CONT  TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
--- PASS: TestAccAWSVpcEndpoint_tags (65.84s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate (256.97s)
=== CONT  TestAccDataSourceAwsVpcEndpoint_interface
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate (251.86s)
=== CONT  TestAccAWSVpcEndpoint_gatewayPolicy
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (46.71s)
=== CONT  TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy (55.03s)
=== CONT  TestAccAWSVpcEndpoint_gatewayBasic
--- PASS: TestAccDataSourceAwsVpcEndpoint_interface (122.58s)
=== CONT  TestAccDataSourceAwsVpcEndpoint_byTags
--- PASS: TestAccDataSourceAwsVpcEndpoint_byTags (27.42s)
=== CONT  TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags
=== CONT  TestAccDataSourceAwsVpcEndpoint_byFilter
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (30.85s)
--- PASS: TestAccDataSourceAwsVpcEndpoint_byFilter (27.70s)
=== CONT  TestAccDataSourceAwsVpcEndpoint_byId
--- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags (29.48s)
=== CONT  TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccDataSourceAwsVpcEndpoint_byId (27.59s)
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (315.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	810.790s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

ACCTEST_PARALLELISM=2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSVpcEndpoint_\|TestAccDataSourceAwsVpcEndpoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSVpcEndpoint_\|TestAccDataSourceAwsVpcEndpoint_ -timeout 120m
=== RUN   TestAccDataSourceAwsVpcEndpoint_gatewayBasic
=== PAUSE TestAccDataSourceAwsVpcEndpoint_gatewayBasic
=== RUN   TestAccDataSourceAwsVpcEndpoint_byId
=== PAUSE TestAccDataSourceAwsVpcEndpoint_byId
=== RUN   TestAccDataSourceAwsVpcEndpoint_byFilter
=== PAUSE TestAccDataSourceAwsVpcEndpoint_byFilter
=== RUN   TestAccDataSourceAwsVpcEndpoint_byTags
=== PAUSE TestAccDataSourceAwsVpcEndpoint_byTags
=== RUN   TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags
=== PAUSE TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags
=== RUN   TestAccDataSourceAwsVpcEndpoint_interface
=== PAUSE TestAccDataSourceAwsVpcEndpoint_interface
=== RUN   TestAccAWSVpcEndpoint_gatewayBasic
=== PAUSE TestAccAWSVpcEndpoint_gatewayBasic
=== RUN   TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
=== RUN   TestAccAWSVpcEndpoint_gatewayPolicy
=== PAUSE TestAccAWSVpcEndpoint_gatewayPolicy
=== RUN   TestAccAWSVpcEndpoint_interfaceBasic
=== PAUSE TestAccAWSVpcEndpoint_interfaceBasic
=== RUN   TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN   TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN   TestAccAWSVpcEndpoint_disappears
=== PAUSE TestAccAWSVpcEndpoint_disappears
=== RUN   TestAccAWSVpcEndpoint_tags
=== PAUSE TestAccAWSVpcEndpoint_tags
=== RUN   TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== PAUSE TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
=== CONT  TestAccDataSourceAwsVpcEndpoint_gatewayBasic
=== CONT  TestAccAWSVpcEndpoint_interfaceBasic
--- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayBasic (23.22s)
=== CONT  TestAccAWSVpcEndpoint_disappears
--- PASS: TestAccAWSVpcEndpoint_disappears (22.20s)
=== CONT  TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer
    resource_aws_lb_test.go:1269: skipping acceptance testing: region does not support ELBv2 Gateway Load Balancers
--- SKIP: TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer (0.37s)
=== CONT  TestAccAWSVpcEndpoint_tags
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (61.90s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate
--- PASS: TestAccAWSVpcEndpoint_tags (49.29s)
=== CONT  TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate (259.65s)
=== CONT  TestAccDataSourceAwsVpcEndpoint_interface
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate (269.48s)
=== CONT  TestAccAWSVpcEndpoint_gatewayPolicy
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (38.38s)
=== CONT  TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy (45.10s)
=== CONT  TestAccAWSVpcEndpoint_gatewayBasic
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (23.50s)
=== CONT  TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccDataSourceAwsVpcEndpoint_interface (158.29s)
=== CONT  TestAccDataSourceAwsVpcEndpoint_byFilter
--- PASS: TestAccDataSourceAwsVpcEndpoint_byFilter (22.47s)
=== CONT  TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags
--- PASS: TestAccDataSourceAwsVpcEndpoint_gatewayWithRouteTableAndTags (23.92s)
=== CONT  TestAccDataSourceAwsVpcEndpoint_byId
--- PASS: TestAccDataSourceAwsVpcEndpoint_byId (22.60s)
=== CONT  TestAccDataSourceAwsVpcEndpoint_byTags
--- PASS: TestAccDataSourceAwsVpcEndpoint_byTags (22.32s)
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (336.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	810.790s

@breathingdust breathingdust merged commit 7d1efab into hashicorp:main Mar 17, 2021
@ghost
Copy link

ghost commented Apr 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit left review comments

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuheiktgw @ewbankkit @breathingdust