Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_network_acl: Correct the ARN account id #17834

Merged
merged 1 commit into from
Mar 17, 2021
Merged

aws_network_acl: Correct the ARN account id #17834

merged 1 commit into from
Mar 17, 2021

Conversation

shuheiktgw
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16978

Output from acceptance testing:

$ TF_ACC=1 go test ./aws -v -count 1 -parallel 10 -run=TestAccAWSNetworkAcl_\|TestAccAWSDefaultNetworkAcl_ -timeout 120m
=== RUN   TestAccAWSDefaultNetworkAcl_basic
=== PAUSE TestAccAWSDefaultNetworkAcl_basic
=== RUN   TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
=== PAUSE TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
=== RUN   TestAccAWSDefaultNetworkAcl_deny_ingress
=== PAUSE TestAccAWSDefaultNetworkAcl_deny_ingress
=== RUN   TestAccAWSDefaultNetworkAcl_withIpv6Ingress
=== PAUSE TestAccAWSDefaultNetworkAcl_withIpv6Ingress
=== RUN   TestAccAWSDefaultNetworkAcl_SubnetRemoval
=== PAUSE TestAccAWSDefaultNetworkAcl_SubnetRemoval
=== RUN   TestAccAWSDefaultNetworkAcl_SubnetReassign
=== PAUSE TestAccAWSDefaultNetworkAcl_SubnetReassign
=== RUN   TestAccAWSNetworkAcl_basic
=== PAUSE TestAccAWSNetworkAcl_basic
=== RUN   TestAccAWSNetworkAcl_tags
=== PAUSE TestAccAWSNetworkAcl_tags
=== RUN   TestAccAWSNetworkAcl_disappears
=== PAUSE TestAccAWSNetworkAcl_disappears
=== RUN   TestAccAWSNetworkAcl_Egress_ConfigMode
=== PAUSE TestAccAWSNetworkAcl_Egress_ConfigMode
=== RUN   TestAccAWSNetworkAcl_Ingress_ConfigMode
=== PAUSE TestAccAWSNetworkAcl_Ingress_ConfigMode
=== RUN   TestAccAWSNetworkAcl_EgressAndIngressRules
=== PAUSE TestAccAWSNetworkAcl_EgressAndIngressRules
=== RUN   TestAccAWSNetworkAcl_OnlyIngressRules_basic
=== PAUSE TestAccAWSNetworkAcl_OnlyIngressRules_basic
=== RUN   TestAccAWSNetworkAcl_OnlyIngressRules_update
=== PAUSE TestAccAWSNetworkAcl_OnlyIngressRules_update
=== RUN   TestAccAWSNetworkAcl_CaseSensitivityNoChanges
=== PAUSE TestAccAWSNetworkAcl_CaseSensitivityNoChanges
=== RUN   TestAccAWSNetworkAcl_OnlyEgressRules
=== PAUSE TestAccAWSNetworkAcl_OnlyEgressRules
=== RUN   TestAccAWSNetworkAcl_SubnetChange
=== PAUSE TestAccAWSNetworkAcl_SubnetChange
=== RUN   TestAccAWSNetworkAcl_Subnets
=== PAUSE TestAccAWSNetworkAcl_Subnets
=== RUN   TestAccAWSNetworkAcl_SubnetsDelete
=== PAUSE TestAccAWSNetworkAcl_SubnetsDelete
=== RUN   TestAccAWSNetworkAcl_ipv6Rules
=== PAUSE TestAccAWSNetworkAcl_ipv6Rules
=== RUN   TestAccAWSNetworkAcl_ipv6ICMPRules
=== PAUSE TestAccAWSNetworkAcl_ipv6ICMPRules
=== RUN   TestAccAWSNetworkAcl_ipv6VpcRules
=== PAUSE TestAccAWSNetworkAcl_ipv6VpcRules
=== RUN   TestAccAWSNetworkAcl_espProtocol
=== PAUSE TestAccAWSNetworkAcl_espProtocol
=== CONT  TestAccAWSDefaultNetworkAcl_basic
=== CONT  TestAccAWSNetworkAcl_OnlyIngressRules_basic
=== CONT  TestAccAWSNetworkAcl_SubnetsDelete
=== CONT  TestAccAWSNetworkAcl_OnlyIngressRules_update
=== CONT  TestAccAWSNetworkAcl_Subnets
=== CONT  TestAccAWSNetworkAcl_SubnetChange
=== CONT  TestAccAWSNetworkAcl_OnlyEgressRules
=== CONT  TestAccAWSNetworkAcl_CaseSensitivityNoChanges
=== CONT  TestAccAWSNetworkAcl_espProtocol
=== CONT  TestAccAWSNetworkAcl_ipv6VpcRules
--- PASS: TestAccAWSDefaultNetworkAcl_basic (86.05s)
=== CONT  TestAccAWSNetworkAcl_ipv6ICMPRules
--- PASS: TestAccAWSNetworkAcl_espProtocol (90.86s)
=== CONT  TestAccAWSNetworkAcl_ipv6Rules
--- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (97.00s)
=== CONT  TestAccAWSNetworkAcl_Egress_ConfigMode
--- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (117.45s)
=== CONT  TestAccAWSNetworkAcl_EgressAndIngressRules
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_basic (118.49s)
=== CONT  TestAccAWSNetworkAcl_Ingress_ConfigMode
--- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (119.54s)
=== CONT  TestAccAWSNetworkAcl_basic
--- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (68.14s)
=== CONT  TestAccAWSNetworkAcl_disappears
--- PASS: TestAccAWSNetworkAcl_SubnetsDelete (157.30s)
=== CONT  TestAccAWSNetworkAcl_tags
--- PASS: TestAccAWSNetworkAcl_Subnets (165.61s)
=== CONT  TestAccAWSDefaultNetworkAcl_deny_ingress
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_update (171.26s)
=== CONT  TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
--- PASS: TestAccAWSNetworkAcl_SubnetChange (179.68s)
=== CONT  TestAccAWSDefaultNetworkAcl_SubnetReassign
--- PASS: TestAccAWSNetworkAcl_ipv6Rules (106.50s)
=== CONT  TestAccAWSDefaultNetworkAcl_SubnetRemoval
--- PASS: TestAccAWSNetworkAcl_basic (90.60s)
=== CONT  TestAccAWSDefaultNetworkAcl_withIpv6Ingress
--- PASS: TestAccAWSNetworkAcl_EgressAndIngressRules (95.94s)
--- PASS: TestAccAWSNetworkAcl_disappears (76.89s)
--- PASS: TestAccAWSDefaultNetworkAcl_deny_ingress (79.23s)
--- PASS: TestAccAWSDefaultNetworkAcl_basicIpv6Vpc (75.02s)
--- PASS: TestAccAWSDefaultNetworkAcl_withIpv6Ingress (60.20s)
--- PASS: TestAccAWSNetworkAcl_Egress_ConfigMode (182.54s)
--- PASS: TestAccAWSNetworkAcl_Ingress_ConfigMode (174.01s)
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetReassign (117.75s)
--- PASS: TestAccAWSNetworkAcl_tags (143.94s)
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetRemoval (107.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	306.426s

Thank you for your review!

@shuheiktgw shuheiktgw requested a review from a team as a code owner February 25, 2021 22:38
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 25, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 25, 2021
@shuheiktgw shuheiktgw mentioned this pull request Feb 25, 2021
Closed
12 tasks
@ewbankkit ewbankkit mentioned this pull request Feb 27, 2021
Closed
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 27, 2021
ewbankkit
ewbankkit approved these changes Feb 27, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSNetworkAcl_\|TestAccAWSDefaultNetworkAcl_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSNetworkAcl_\|TestAccAWSDefaultNetworkAcl_ -timeout 120m
=== RUN   TestAccAWSDefaultNetworkAcl_basic
=== PAUSE TestAccAWSDefaultNetworkAcl_basic
=== RUN   TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
=== PAUSE TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
=== RUN   TestAccAWSDefaultNetworkAcl_deny_ingress
=== PAUSE TestAccAWSDefaultNetworkAcl_deny_ingress
=== RUN   TestAccAWSDefaultNetworkAcl_withIpv6Ingress
=== PAUSE TestAccAWSDefaultNetworkAcl_withIpv6Ingress
=== RUN   TestAccAWSDefaultNetworkAcl_SubnetRemoval
=== PAUSE TestAccAWSDefaultNetworkAcl_SubnetRemoval
=== RUN   TestAccAWSDefaultNetworkAcl_SubnetReassign
=== PAUSE TestAccAWSDefaultNetworkAcl_SubnetReassign
=== RUN   TestAccAWSNetworkAcl_basic
=== PAUSE TestAccAWSNetworkAcl_basic
=== RUN   TestAccAWSNetworkAcl_tags
=== PAUSE TestAccAWSNetworkAcl_tags
=== RUN   TestAccAWSNetworkAcl_disappears
=== PAUSE TestAccAWSNetworkAcl_disappears
=== RUN   TestAccAWSNetworkAcl_Egress_ConfigMode
=== PAUSE TestAccAWSNetworkAcl_Egress_ConfigMode
=== RUN   TestAccAWSNetworkAcl_Ingress_ConfigMode
=== PAUSE TestAccAWSNetworkAcl_Ingress_ConfigMode
=== RUN   TestAccAWSNetworkAcl_EgressAndIngressRules
=== PAUSE TestAccAWSNetworkAcl_EgressAndIngressRules
=== RUN   TestAccAWSNetworkAcl_OnlyIngressRules_basic
=== PAUSE TestAccAWSNetworkAcl_OnlyIngressRules_basic
=== RUN   TestAccAWSNetworkAcl_OnlyIngressRules_update
=== PAUSE TestAccAWSNetworkAcl_OnlyIngressRules_update
=== RUN   TestAccAWSNetworkAcl_CaseSensitivityNoChanges
=== PAUSE TestAccAWSNetworkAcl_CaseSensitivityNoChanges
=== RUN   TestAccAWSNetworkAcl_OnlyEgressRules
=== PAUSE TestAccAWSNetworkAcl_OnlyEgressRules
=== RUN   TestAccAWSNetworkAcl_SubnetChange
=== PAUSE TestAccAWSNetworkAcl_SubnetChange
=== RUN   TestAccAWSNetworkAcl_Subnets
=== PAUSE TestAccAWSNetworkAcl_Subnets
=== RUN   TestAccAWSNetworkAcl_SubnetsDelete
=== PAUSE TestAccAWSNetworkAcl_SubnetsDelete
=== RUN   TestAccAWSNetworkAcl_ipv6Rules
=== PAUSE TestAccAWSNetworkAcl_ipv6Rules
=== RUN   TestAccAWSNetworkAcl_ipv6ICMPRules
=== PAUSE TestAccAWSNetworkAcl_ipv6ICMPRules
=== RUN   TestAccAWSNetworkAcl_ipv6VpcRules
=== PAUSE TestAccAWSNetworkAcl_ipv6VpcRules
=== RUN   TestAccAWSNetworkAcl_espProtocol
=== PAUSE TestAccAWSNetworkAcl_espProtocol
=== CONT  TestAccAWSDefaultNetworkAcl_basic
=== CONT  TestAccAWSNetworkAcl_OnlyIngressRules_basic
--- PASS: TestAccAWSDefaultNetworkAcl_basic (23.47s)
=== CONT  TestAccAWSNetworkAcl_espProtocol
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_basic (45.89s)
=== CONT  TestAccAWSNetworkAcl_ipv6VpcRules
--- PASS: TestAccAWSNetworkAcl_espProtocol (26.68s)
=== CONT  TestAccAWSNetworkAcl_ipv6ICMPRules
--- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (19.29s)
=== CONT  TestAccAWSNetworkAcl_ipv6Rules
--- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (26.93s)
=== CONT  TestAccAWSNetworkAcl_SubnetsDelete
--- PASS: TestAccAWSNetworkAcl_ipv6Rules (43.08s)
=== CONT  TestAccAWSNetworkAcl_Subnets
--- PASS: TestAccAWSNetworkAcl_SubnetsDelete (58.57s)
=== CONT  TestAccAWSNetworkAcl_SubnetChange
--- PASS: TestAccAWSNetworkAcl_Subnets (63.75s)
=== CONT  TestAccAWSNetworkAcl_OnlyEgressRules
=== CONT  TestAccAWSNetworkAcl_SubnetChange
    resource_aws_network_acl_test.go:489: Step 3/3 error: Error running apply: exit status 1
        2021/02/27 16:43:28 [DEBUG] Using modified User-Agent: Terraform/0.12.26 HashiCorp-terraform-exec/0.13.0
        
        Error: InvalidAssociationID.NotFound: The association ID 'aclassoc-045cd458fc1b87e13' does not exist
        	status code: 400, request id: d36ff582-4ab3-4171-b832-7b61c80cf905
        
          on terraform_plugin_test.tf line 30, in resource "aws_network_acl" "test":
          30: resource "aws_network_acl" "test" {
        
        
--- FAIL: TestAccAWSNetworkAcl_SubnetChange (52.24s)
=== CONT  TestAccAWSNetworkAcl_CaseSensitivityNoChanges
--- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (37.79s)
=== CONT  TestAccAWSNetworkAcl_OnlyIngressRules_update
--- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (43.46s)
=== CONT  TestAccAWSNetworkAcl_basic
--- PASS: TestAccAWSNetworkAcl_basic (31.75s)
=== CONT  TestAccAWSNetworkAcl_EgressAndIngressRules
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_update (65.30s)
=== CONT  TestAccAWSNetworkAcl_Ingress_ConfigMode
--- PASS: TestAccAWSNetworkAcl_EgressAndIngressRules (38.05s)
=== CONT  TestAccAWSNetworkAcl_Egress_ConfigMode
--- PASS: TestAccAWSNetworkAcl_Ingress_ConfigMode (59.07s)
=== CONT  TestAccAWSNetworkAcl_disappears
--- PASS: TestAccAWSNetworkAcl_Egress_ConfigMode (59.07s)
=== CONT  TestAccAWSNetworkAcl_tags
--- PASS: TestAccAWSNetworkAcl_disappears (31.71s)
=== CONT  TestAccAWSDefaultNetworkAcl_withIpv6Ingress
--- PASS: TestAccAWSDefaultNetworkAcl_withIpv6Ingress (21.89s)
=== CONT  TestAccAWSDefaultNetworkAcl_SubnetReassign
--- PASS: TestAccAWSNetworkAcl_tags (54.21s)
=== CONT  TestAccAWSDefaultNetworkAcl_SubnetRemoval
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetReassign (57.72s)
=== CONT  TestAccAWSDefaultNetworkAcl_deny_ingress
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetRemoval (49.33s)
=== CONT  TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
--- PASS: TestAccAWSDefaultNetworkAcl_deny_ingress (21.66s)
--- PASS: TestAccAWSDefaultNetworkAcl_basicIpv6Vpc (22.65s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	482.256s
FAIL
GNUmakefile:27: recipe for target 'testacc' failed
make: *** [testacc] Error 1

Failure is unrelated to the change. Opened issue #17857.

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @shuheiktgw!

As noted by Kit, test failure is not related but interesting that it passes in GovCloud.

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSNetworkAcl_\|TestAccAWSDefaultNetworkAcl_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSNetworkAcl_\|TestAccAWSDefaultNetworkAcl_ -timeout 120m
=== RUN   TestAccAWSDefaultNetworkAcl_basic
=== PAUSE TestAccAWSDefaultNetworkAcl_basic
=== RUN   TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
=== PAUSE TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
=== RUN   TestAccAWSDefaultNetworkAcl_deny_ingress
=== PAUSE TestAccAWSDefaultNetworkAcl_deny_ingress
=== RUN   TestAccAWSDefaultNetworkAcl_withIpv6Ingress
=== PAUSE TestAccAWSDefaultNetworkAcl_withIpv6Ingress
=== RUN   TestAccAWSDefaultNetworkAcl_SubnetRemoval
=== PAUSE TestAccAWSDefaultNetworkAcl_SubnetRemoval
=== RUN   TestAccAWSDefaultNetworkAcl_SubnetReassign
=== PAUSE TestAccAWSDefaultNetworkAcl_SubnetReassign
=== RUN   TestAccAWSNetworkAcl_basic
=== PAUSE TestAccAWSNetworkAcl_basic
=== RUN   TestAccAWSNetworkAcl_tags
=== PAUSE TestAccAWSNetworkAcl_tags
=== RUN   TestAccAWSNetworkAcl_disappears
=== PAUSE TestAccAWSNetworkAcl_disappears
=== RUN   TestAccAWSNetworkAcl_Egress_ConfigMode
=== PAUSE TestAccAWSNetworkAcl_Egress_ConfigMode
=== RUN   TestAccAWSNetworkAcl_Ingress_ConfigMode
=== PAUSE TestAccAWSNetworkAcl_Ingress_ConfigMode
=== RUN   TestAccAWSNetworkAcl_EgressAndIngressRules
=== PAUSE TestAccAWSNetworkAcl_EgressAndIngressRules
=== RUN   TestAccAWSNetworkAcl_OnlyIngressRules_basic
=== PAUSE TestAccAWSNetworkAcl_OnlyIngressRules_basic
=== RUN   TestAccAWSNetworkAcl_OnlyIngressRules_update
=== PAUSE TestAccAWSNetworkAcl_OnlyIngressRules_update
=== RUN   TestAccAWSNetworkAcl_CaseSensitivityNoChanges
=== PAUSE TestAccAWSNetworkAcl_CaseSensitivityNoChanges
=== RUN   TestAccAWSNetworkAcl_OnlyEgressRules
=== PAUSE TestAccAWSNetworkAcl_OnlyEgressRules
=== RUN   TestAccAWSNetworkAcl_SubnetChange
=== PAUSE TestAccAWSNetworkAcl_SubnetChange
=== RUN   TestAccAWSNetworkAcl_Subnets
=== PAUSE TestAccAWSNetworkAcl_Subnets
=== RUN   TestAccAWSNetworkAcl_SubnetsDelete
=== PAUSE TestAccAWSNetworkAcl_SubnetsDelete
=== RUN   TestAccAWSNetworkAcl_ipv6Rules
=== PAUSE TestAccAWSNetworkAcl_ipv6Rules
=== RUN   TestAccAWSNetworkAcl_ipv6ICMPRules
=== PAUSE TestAccAWSNetworkAcl_ipv6ICMPRules
=== RUN   TestAccAWSNetworkAcl_ipv6VpcRules
=== PAUSE TestAccAWSNetworkAcl_ipv6VpcRules
=== RUN   TestAccAWSNetworkAcl_espProtocol
=== PAUSE TestAccAWSNetworkAcl_espProtocol
=== CONT  TestAccAWSDefaultNetworkAcl_basic
=== CONT  TestAccAWSNetworkAcl_OnlyIngressRules_basic
--- PASS: TestAccAWSDefaultNetworkAcl_basic (18.65s)
=== CONT  TestAccAWSNetworkAcl_SubnetsDelete
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_basic (36.61s)
=== CONT  TestAccAWSNetworkAcl_espProtocol
--- PASS: TestAccAWSNetworkAcl_espProtocol (19.56s)
=== CONT  TestAccAWSNetworkAcl_ipv6VpcRules
--- PASS: TestAccAWSNetworkAcl_SubnetsDelete (41.42s)
=== CONT  TestAccAWSNetworkAcl_ipv6ICMPRules
--- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (14.93s)
=== CONT  TestAccAWSNetworkAcl_ipv6Rules
--- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (20.06s)
=== CONT  TestAccAWSNetworkAcl_OnlyEgressRules
--- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (31.39s)
=== CONT  TestAccAWSNetworkAcl_Subnets
--- PASS: TestAccAWSNetworkAcl_ipv6Rules (44.30s)
=== CONT  TestAccAWSNetworkAcl_SubnetChange
--- PASS: TestAccAWSNetworkAcl_Subnets (47.31s)
=== CONT  TestAccAWSNetworkAcl_CaseSensitivityNoChanges
=== CONT  TestAccAWSNetworkAcl_SubnetChange
    resource_aws_network_acl_test.go:489: Step 3/3 error: Error running apply: exit status 1
        2021/03/17 15:20:32 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.13.0

        Error: InvalidAssociationID.NotFound: The association ID 'aclassoc-0b6877f42e726c5e9' does not exist
        	status code: 400, request id: e8ad686d-e177-4988-9c25-2c366ed8642f

          on terraform_plugin_test.tf line 30, in resource "aws_network_acl" "test":
          30: resource "aws_network_acl" "test" {


--- FAIL: TestAccAWSNetworkAcl_SubnetChange (43.37s)
=== CONT  TestAccAWSNetworkAcl_OnlyIngressRules_update
--- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (34.37s)
=== CONT  TestAccAWSNetworkAcl_basic
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_update (50.42s)
=== CONT  TestAccAWSNetworkAcl_EgressAndIngressRules
--- PASS: TestAccAWSNetworkAcl_basic (28.77s)
=== CONT  TestAccAWSNetworkAcl_Ingress_ConfigMode
--- PASS: TestAccAWSNetworkAcl_EgressAndIngressRules (31.92s)
=== CONT  TestAccAWSNetworkAcl_Egress_ConfigMode
--- PASS: TestAccAWSNetworkAcl_Ingress_ConfigMode (48.88s)
=== CONT  TestAccAWSNetworkAcl_disappears
--- PASS: TestAccAWSNetworkAcl_Egress_ConfigMode (44.65s)
=== CONT  TestAccAWSNetworkAcl_tags
--- PASS: TestAccAWSNetworkAcl_disappears (25.66s)
=== CONT  TestAccAWSDefaultNetworkAcl_withIpv6Ingress
--- PASS: TestAccAWSDefaultNetworkAcl_withIpv6Ingress (16.53s)
=== CONT  TestAccAWSDefaultNetworkAcl_SubnetReassign
--- PASS: TestAccAWSNetworkAcl_tags (40.73s)
=== CONT  TestAccAWSDefaultNetworkAcl_SubnetRemoval
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetReassign (42.52s)
=== CONT  TestAccAWSDefaultNetworkAcl_deny_ingress
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetRemoval (35.58s)
=== CONT  TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
--- PASS: TestAccAWSDefaultNetworkAcl_deny_ingress (16.73s)
--- PASS: TestAccAWSDefaultNetworkAcl_basicIpv6Vpc (16.83s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	385.528s
FAIL
make: *** [testacc] Error 1

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSNetworkAcl_\|TestAccAWSDefaultNetworkAcl_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSNetworkAcl_\|TestAccAWSDefaultNetworkAcl_ -timeout 120m
=== RUN   TestAccAWSDefaultNetworkAcl_basic
=== PAUSE TestAccAWSDefaultNetworkAcl_basic
=== RUN   TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
=== PAUSE TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
=== RUN   TestAccAWSDefaultNetworkAcl_deny_ingress
=== PAUSE TestAccAWSDefaultNetworkAcl_deny_ingress
=== RUN   TestAccAWSDefaultNetworkAcl_withIpv6Ingress
=== PAUSE TestAccAWSDefaultNetworkAcl_withIpv6Ingress
=== RUN   TestAccAWSDefaultNetworkAcl_SubnetRemoval
=== PAUSE TestAccAWSDefaultNetworkAcl_SubnetRemoval
=== RUN   TestAccAWSDefaultNetworkAcl_SubnetReassign
=== PAUSE TestAccAWSDefaultNetworkAcl_SubnetReassign
=== RUN   TestAccAWSNetworkAcl_basic
=== PAUSE TestAccAWSNetworkAcl_basic
=== RUN   TestAccAWSNetworkAcl_tags
=== PAUSE TestAccAWSNetworkAcl_tags
=== RUN   TestAccAWSNetworkAcl_disappears
=== PAUSE TestAccAWSNetworkAcl_disappears
=== RUN   TestAccAWSNetworkAcl_Egress_ConfigMode
=== PAUSE TestAccAWSNetworkAcl_Egress_ConfigMode
=== RUN   TestAccAWSNetworkAcl_Ingress_ConfigMode
=== PAUSE TestAccAWSNetworkAcl_Ingress_ConfigMode
=== RUN   TestAccAWSNetworkAcl_EgressAndIngressRules
=== PAUSE TestAccAWSNetworkAcl_EgressAndIngressRules
=== RUN   TestAccAWSNetworkAcl_OnlyIngressRules_basic
=== PAUSE TestAccAWSNetworkAcl_OnlyIngressRules_basic
=== RUN   TestAccAWSNetworkAcl_OnlyIngressRules_update
=== PAUSE TestAccAWSNetworkAcl_OnlyIngressRules_update
=== RUN   TestAccAWSNetworkAcl_CaseSensitivityNoChanges
=== PAUSE TestAccAWSNetworkAcl_CaseSensitivityNoChanges
=== RUN   TestAccAWSNetworkAcl_OnlyEgressRules
=== PAUSE TestAccAWSNetworkAcl_OnlyEgressRules
=== RUN   TestAccAWSNetworkAcl_SubnetChange
=== PAUSE TestAccAWSNetworkAcl_SubnetChange
=== RUN   TestAccAWSNetworkAcl_Subnets
=== PAUSE TestAccAWSNetworkAcl_Subnets
=== RUN   TestAccAWSNetworkAcl_SubnetsDelete
=== PAUSE TestAccAWSNetworkAcl_SubnetsDelete
=== RUN   TestAccAWSNetworkAcl_ipv6Rules
=== PAUSE TestAccAWSNetworkAcl_ipv6Rules
=== RUN   TestAccAWSNetworkAcl_ipv6ICMPRules
=== PAUSE TestAccAWSNetworkAcl_ipv6ICMPRules
=== RUN   TestAccAWSNetworkAcl_ipv6VpcRules
=== PAUSE TestAccAWSNetworkAcl_ipv6VpcRules
=== RUN   TestAccAWSNetworkAcl_espProtocol
=== PAUSE TestAccAWSNetworkAcl_espProtocol
=== CONT  TestAccAWSDefaultNetworkAcl_basic
=== CONT  TestAccAWSNetworkAcl_OnlyIngressRules_basic
--- PASS: TestAccAWSDefaultNetworkAcl_basic (13.07s)
=== CONT  TestAccAWSNetworkAcl_espProtocol
--- PASS: TestAccAWSNetworkAcl_espProtocol (15.70s)
=== CONT  TestAccAWSNetworkAcl_ipv6VpcRules
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_basic (29.47s)
=== CONT  TestAccAWSNetworkAcl_ipv6ICMPRules
--- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (12.19s)
=== CONT  TestAccAWSNetworkAcl_ipv6Rules
--- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (16.80s)
=== CONT  TestAccAWSNetworkAcl_SubnetsDelete
--- PASS: TestAccAWSNetworkAcl_ipv6Rules (28.33s)
=== CONT  TestAccAWSNetworkAcl_CaseSensitivityNoChanges
--- PASS: TestAccAWSNetworkAcl_SubnetsDelete (32.85s)
=== CONT  TestAccAWSNetworkAcl_OnlyIngressRules_update
--- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (27.58s)
=== CONT  TestAccAWSNetworkAcl_Subnets
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_update (41.30s)
=== CONT  TestAccAWSNetworkAcl_SubnetChange
--- PASS: TestAccAWSNetworkAcl_Subnets (34.01s)
=== CONT  TestAccAWSNetworkAcl_basic
--- PASS: TestAccAWSNetworkAcl_basic (23.01s)
=== CONT  TestAccAWSNetworkAcl_EgressAndIngressRules
--- PASS: TestAccAWSNetworkAcl_SubnetChange (44.01s)
=== CONT  TestAccAWSNetworkAcl_Ingress_ConfigMode
--- PASS: TestAccAWSNetworkAcl_EgressAndIngressRules (25.22s)
=== CONT  TestAccAWSNetworkAcl_Egress_ConfigMode
--- PASS: TestAccAWSNetworkAcl_Ingress_ConfigMode (33.80s)
=== CONT  TestAccAWSNetworkAcl_disappears
=== CONT  TestAccAWSNetworkAcl_tags
--- PASS: TestAccAWSNetworkAcl_Egress_ConfigMode (34.22s)
--- PASS: TestAccAWSNetworkAcl_disappears (22.47s)
=== CONT  TestAccAWSDefaultNetworkAcl_withIpv6Ingress
--- PASS: TestAccAWSDefaultNetworkAcl_withIpv6Ingress (13.00s)
=== CONT  TestAccAWSNetworkAcl_OnlyEgressRules
--- PASS: TestAccAWSNetworkAcl_tags (31.72s)
=== CONT  TestAccAWSDefaultNetworkAcl_SubnetRemoval
--- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (26.03s)
=== CONT  TestAccAWSDefaultNetworkAcl_SubnetReassign
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetRemoval (27.81s)
=== CONT  TestAccAWSDefaultNetworkAcl_deny_ingress
--- PASS: TestAccAWSDefaultNetworkAcl_deny_ingress (14.53s)
=== CONT  TestAccAWSDefaultNetworkAcl_basicIpv6Vpc
--- PASS: TestAccAWSDefaultNetworkAcl_SubnetReassign (35.76s)
--- PASS: TestAccAWSDefaultNetworkAcl_basicIpv6Vpc (13.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	304.699s

@breathingdust breathingdust merged commit b68643b into hashicorp:main Mar 17, 2021
@shuheiktgw shuheiktgw deleted the correct_aws_network_acl_arn branch March 22, 2021 23:37
@ghost
Copy link

ghost commented Apr 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuheiktgw @breathingdust @ewbankkit