Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_acm_certificate: Trigger resource recreation on VALIDATION_TIMED_OUT status #17869

Merged
merged 3 commits into from
Mar 4, 2021
Merged

resource/aws_acm_certificate: Trigger resource recreation on VALIDATION_TIMED_OUT status #17869

merged 3 commits into from
Mar 4, 2021

Commits on Mar 1, 2021

  1. resource/aws_acm_certificate: Trigger resource recreation on VALIDATI… 

    …ON_TIMED_OUT status

Reference: #17799

This change is not pragmatic for acceptance testing as it requires 72 hours to trigger the behavior, but acceptance testing is used for finding any regresions.

Output from acceptance testing:

```
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (28.63s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (33.31s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (26.54s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (46.51s)
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (19.45s)
--- PASS: TestAccAWSAcmCertificate_privateCert (22.21s)
--- PASS: TestAccAWSAcmCertificate_PrivateKey_Tags (34.60s)
--- PASS: TestAccAWSAcmCertificate_root (33.01s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (4.08s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (26.85s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (35.05s)
--- PASS: TestAccAWSAcmCertificate_san_single (28.67s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (38.97s)
--- PASS: TestAccAWSAcmCertificate_SubjectAlternativeNames_EmptyString (4.00s)
--- PASS: TestAccAWSAcmCertificate_tags (60.14s)
--- PASS: TestAccAWSAcmCertificate_wildcard (25.46s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (29.57s)
```
    @bflad
    bflad committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    6d92656 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG for #17869

    @bflad
    bflad committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    c3acd86 View commit details
    Browse the repository at this point in the history

  3. resource/aws_acm_certificate: Fix error message typos

    @bflad
    bflad committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    0d8f867 View commit details
    Browse the repository at this point in the history