Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/glue_catalog_database - add target_database argument #19371

Merged
merged 5 commits into from
May 17, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented May 13, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15296

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueCatalogDatabase_'
--- PASS: TestAccAWSGlueCatalogDatabase_disappears (25.77s)
--- PASS: TestAccAWSGlueCatalogDatabase_targetDatabase (41.92s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (86.02s)

@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 13, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label May 13, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review May 13, 2021 21:35
@DrFaust92 DrFaust92 requested a review from a team as a code owner May 13, 2021 21:35
@YakDriver YakDriver self-assigned this May 17, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

Output of acceptance tests on commercial:

--- PASS: TestAccAWSGlueCatalogDatabase_disappears (9.86s)
--- PASS: TestAccAWSGlueCatalogDatabase_targetDatabase (16.28s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (29.20s)

Output of acceptance tests on GovCloud:

--- PASS: TestAccAWSGlueCatalogDatabase_disappears (13.11s)
--- PASS: TestAccAWSGlueCatalogDatabase_targetDatabase (19.03s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (39.43s)

@YakDriver YakDriver added this to the v3.41.0 milestone May 17, 2021
@YakDriver YakDriver merged commit 002e91f into hashicorp:main May 17, 2021
@DrFaust92 DrFaust92 deleted the r/glue_catalog_database_target branch May 17, 2021 20:08
@ghost
Copy link

ghost commented May 19, 2021

This has been released in version 3.41.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants