r/aws_pinpointsmsvoicev2_phone_number - new resource #25036

JamesMarino · 2022-05-25T13:59:19Z

This PR adds a new AWS service pinpointsmsvoicev2 and new resources aws_pinpointsmsvoicev2_phone_number and aws_pinpointsmsvoicev2_opt_out_list.

Note: aws_pinpointsmsvoicev2_opt_out_list was added as it is a dependant of aws_pinpointsmsvoicev2_phone_number in its tests.

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24855

Output from acceptance testing:

$ make testacc PKG=pinpointsmsvoicev2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/pinpointsmsvoicev2/... -v -count 1 -parallel 20   -timeout 180m
=== RUN   TestAccPinpointSMSVoiceV2OptOutList_basic
=== PAUSE TestAccPinpointSMSVoiceV2OptOutList_basic
=== RUN   TestAccPinpointSMSVoiceV2OptOutList_disappears
=== PAUSE TestAccPinpointSMSVoiceV2OptOutList_disappears
=== RUN   TestAccPinpointSMSVoiceV2PhoneNumber_basic
=== PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_basic
=== RUN   TestAccPinpointSMSVoiceV2PhoneNumber_full
=== PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_full
=== RUN   TestAccPinpointSMSVoiceV2PhoneNumber_disappears
=== PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_disappears
=== CONT  TestAccPinpointSMSVoiceV2OptOutList_basic
=== CONT  TestAccPinpointSMSVoiceV2PhoneNumber_full
=== CONT  TestAccPinpointSMSVoiceV2PhoneNumber_disappears
=== CONT  TestAccPinpointSMSVoiceV2PhoneNumber_basic
=== CONT  TestAccPinpointSMSVoiceV2OptOutList_disappears
--- PASS: TestAccPinpointSMSVoiceV2OptOutList_disappears (10.15s)
--- PASS: TestAccPinpointSMSVoiceV2OptOutList_basic (14.02s)
--- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_full (24.11s)
--- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_basic (25.03s)
--- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_disappears (31.44s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/pinpointsmsvoicev2 33.707s

github-actions

Welcome @JamesMarino 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

JamesMarino · 2023-01-12T01:44:30Z

Any news on whether we can get this merged in or if there was any feedback? Happy to fix up the conflicts.

cemo · 2023-12-20T17:01:48Z

@jar-b can you please assign this for review? I would like to send PRs to close other missing resources on pinpoint. Thanks

dabmajor · 2024-06-24T17:45:12Z

Is someone going to pick this back up? I've currently implemented a solution using null_resources and external data resources; however, bringing this back to a standard terraform provider would be fantastic :)

ewbankkit · 2024-09-13T15:10:46Z

@dabmajor This in on the maintainers' roadmap for this quarter.

# Conflicts: # .github/labeler-issue-triage.yml # .github/labeler-pr-triage.yml # infrastructure/repository/labels-service.tf # internal/conns/awsclient_gen.go # internal/conns/config_gen.go # internal/provider/provider.go # names/consts_gen.go # names/names_data.csv # website/allowed-subcategories.txt # website/docs/guides/custom-service-endpoints.html.markdown

…tance tests.

github-actions · 2024-09-13T20:00:02Z

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

Check open pull requests with the dependencies label to view other dependency updates.
If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
If this pull request is for supporting a new AWS service:
- Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
- If this pull request is already a separate pull request from the above item, you can ignore this message.

% make testacc TESTARGS='-run=TestAccPinpointSMSVoiceV2OptOutList_' PKG=pinpointsmsvoicev2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.6 test ./internal/service/pinpointsmsvoicev2/... -v -count 1 -parallel 20 -run=TestAccPinpointSMSVoiceV2OptOutList_ -timeout 360m === RUN TestAccPinpointSMSVoiceV2OptOutList_basic === PAUSE TestAccPinpointSMSVoiceV2OptOutList_basic === RUN TestAccPinpointSMSVoiceV2OptOutList_disappears === PAUSE TestAccPinpointSMSVoiceV2OptOutList_disappears === RUN TestAccPinpointSMSVoiceV2OptOutList_tags === PAUSE TestAccPinpointSMSVoiceV2OptOutList_tags === CONT TestAccPinpointSMSVoiceV2OptOutList_basic === CONT TestAccPinpointSMSVoiceV2OptOutList_tags === CONT TestAccPinpointSMSVoiceV2OptOutList_disappears --- PASS: TestAccPinpointSMSVoiceV2OptOutList_disappears (13.50s) --- PASS: TestAccPinpointSMSVoiceV2OptOutList_basic (15.71s) --- PASS: TestAccPinpointSMSVoiceV2OptOutList_tags (33.37s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/pinpointsmsvoicev2 38.259s

… acceptance tests.

% make testacc TESTARGS='-run=TestAccPinpointSMSVoiceV2PhoneNumber_' PKG=pinpointsmsvoicev2 ACCTEST_PARALLELISM=2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.6 test ./internal/service/pinpointsmsvoicev2/... -v -count 1 -parallel 2 -run=TestAccPinpointSMSVoiceV2PhoneNumber_ -timeout 360m === RUN TestAccPinpointSMSVoiceV2PhoneNumber_basic === PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_basic === RUN TestAccPinpointSMSVoiceV2PhoneNumber_full === PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_full === RUN TestAccPinpointSMSVoiceV2PhoneNumber_disappears === PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_disappears === RUN TestAccPinpointSMSVoiceV2PhoneNumber_tags === PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_tags === CONT TestAccPinpointSMSVoiceV2PhoneNumber_basic === CONT TestAccPinpointSMSVoiceV2PhoneNumber_disappears --- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_basic (19.22s) === CONT TestAccPinpointSMSVoiceV2PhoneNumber_full --- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_disappears (25.43s) === CONT TestAccPinpointSMSVoiceV2PhoneNumber_tags --- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_full (33.86s) --- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_tags (36.83s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/pinpointsmsvoicev2 67.075s

…in resources.

…in documentation.

…amework.

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccPinpointSMSVoiceV2OptOutList_' PKG=pinpointsmsvoicev2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/pinpointsmsvoicev2/... -v -count 1 -parallel 20  -run=TestAccPinpointSMSVoiceV2OptOutList_ -timeout 360m
=== RUN   TestAccPinpointSMSVoiceV2OptOutList_basic
=== PAUSE TestAccPinpointSMSVoiceV2OptOutList_basic
=== RUN   TestAccPinpointSMSVoiceV2OptOutList_disappears
=== PAUSE TestAccPinpointSMSVoiceV2OptOutList_disappears
=== RUN   TestAccPinpointSMSVoiceV2OptOutList_tags
=== PAUSE TestAccPinpointSMSVoiceV2OptOutList_tags
=== CONT  TestAccPinpointSMSVoiceV2OptOutList_basic
=== CONT  TestAccPinpointSMSVoiceV2OptOutList_tags
=== CONT  TestAccPinpointSMSVoiceV2OptOutList_disappears
--- PASS: TestAccPinpointSMSVoiceV2OptOutList_disappears (11.53s)
--- PASS: TestAccPinpointSMSVoiceV2OptOutList_basic (14.10s)
--- PASS: TestAccPinpointSMSVoiceV2OptOutList_tags (30.27s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pinpointsmsvoicev2	35.355s

% make testacc TESTARGS='-run=TestAccPinpointSMSVoiceV2PhoneNumber_' PKG=pinpointsmsvoicev2 ACCTEST_PARALLELISM=2 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/pinpointsmsvoicev2/... -v -count 1 -parallel 2  -run=TestAccPinpointSMSVoiceV2PhoneNumber_ -timeout 360m
=== RUN   TestAccPinpointSMSVoiceV2PhoneNumber_basic
=== PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_basic
=== RUN   TestAccPinpointSMSVoiceV2PhoneNumber_full
=== PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_full
=== RUN   TestAccPinpointSMSVoiceV2PhoneNumber_disappears
=== PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_disappears
=== RUN   TestAccPinpointSMSVoiceV2PhoneNumber_tags
=== PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_tags
=== CONT  TestAccPinpointSMSVoiceV2PhoneNumber_basic
=== CONT  TestAccPinpointSMSVoiceV2PhoneNumber_disappears
--- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_basic (17.39s)
=== CONT  TestAccPinpointSMSVoiceV2PhoneNumber_tags
--- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_disappears (21.77s)
=== CONT  TestAccPinpointSMSVoiceV2PhoneNumber_full
--- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_full (29.72s)
--- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_tags (36.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pinpointsmsvoicev2	58.481s

github-actions · 2024-09-20T12:44:45Z

This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

JamesMarino added 5 commits May 25, 2022 19:42

feat: pinpoint phone number resource

84c22f8

feat: pinpoint opt out list resource

9ad391d

fix: code cleanup and added more tests

a139456

docs: added in documentation

7e4ebfd

fix: linting fixes

86e1c31

docs: added resources in changelog

2aac8a6

github-actions bot reviewed May 25, 2022

View reviewed changes

justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 25, 2022

ewbankkit added the service/pinpointsmsvoice Issues and PRs that pertain to the pinpointsmsvoice service. label Aug 4, 2022

JamesMarino mentioned this pull request Feb 4, 2023

Add new AWS Pinpoint resource aws_pinpoint_phone_number #24855

Closed

ewbankkit self-assigned this Sep 13, 2024

github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 13, 2024

ewbankkit added 3 commits September 13, 2024 12:40

pinpointsmsvoicev2: Use AWS SDK for Go v2.

db2e552

Run 'make gen'.

48c5812

ewbankkit added 5 commits September 13, 2024 15:38

Add 'sdkv2.HasNonZeroValues'.

342398a

r/aws_pinpointsmsvoicev2_phone_number: Avoid update-after-create.

ccd0b0f

r/aws_pinpointsmsvoicev2_phone_number: 'number_capabilities' is a set.

652dd7f

r/aws_pinpointsmsvoicev2_phone_number: Use ConfigStateChecks in accep…

61e9ff1

…tance tests.

Fix golangci-lint 'unparam'.

d3978ea

ewbankkit requested review from breathingdust, justinretzolk and a team as code owners September 13, 2024 19:59

ewbankkit added 15 commits September 13, 2024 17:03

r/aws_pinpointsmsvoicev2_phone_number: Add sweeper.

f15f207

Run 'make gen'.

170f8db

pinpoint: Generate paginator.

1c190fb

r/aws_pinpoint_app: Tidy up sweeper.

761aaae

r/aws_pinpointsmsvoicev2_phone_number: Use SIMULATOR phone numbers in…

fa755bb

… acceptance tests.

pinpointsmsvoicev2: Human-friendly name is 'End User Messaging SMS'.

ced48c9

pinpointsmsvoicev2: 'End User Messaging' -> 'End User Messaging SMS' …

029a5e5

…in resources.

pinpointsmsvoicev2: 'End User Messaging' -> 'End User Messaging SMS' …

9048865

…in documentation.

README not used.

a57db51

Merge branch 'main' into HEAD

48b92f6

pinpointsmsvoicev2: Remove 'sdk.client_version'.

f91ed53

r/aws_pinpointsmsvoicev2_opt_out_list: Migrate to Terraform Plugin Fr…

b5b33f5

…amework.

r/aws_pinpointsmsvoicev2_phone_number: Migrate to Terraform Plugin Fr…

a3c56d1

…amework.

ewbankkit approved these changes Sep 16, 2024

View reviewed changes

Fix golangci-lint 'nolintlint'.

62ca78f

ewbankkit merged commit 81a5e59 into hashicorp:main Sep 16, 2024
49 checks passed

github-actions bot added this to the v5.68.0 milestone Sep 16, 2024

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_pinpointsmsvoicev2_phone_number - new resource #25036

r/aws_pinpointsmsvoicev2_phone_number - new resource #25036

JamesMarino commented May 25, 2022

github-actions bot left a comment

JamesMarino commented Jan 12, 2023 •

edited

Loading

cemo commented Dec 20, 2023

dabmajor commented Jun 24, 2024

ewbankkit commented Sep 13, 2024

github-actions bot commented Sep 13, 2024

ewbankkit left a comment •

edited

Loading

github-actions bot commented Sep 20, 2024

r/aws_pinpointsmsvoicev2_phone_number - new resource #25036

r/aws_pinpointsmsvoicev2_phone_number - new resource #25036

Conversation

JamesMarino commented May 25, 2022

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

JamesMarino commented Jan 12, 2023 • edited Loading

cemo commented Dec 20, 2023

dabmajor commented Jun 24, 2024

ewbankkit commented Sep 13, 2024

github-actions bot commented Sep 13, 2024

ewbankkit left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Sep 20, 2024

JamesMarino commented Jan 12, 2023 •

edited

Loading

ewbankkit left a comment •

edited

Loading