Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r//aws_prometheus_workspace: Create a logging configuration on resource update if none existed previously #29237

Merged
merged 8 commits into from
Feb 3, 2023

Conversation

ewbankkit
Copy link
Contributor

Description

When updating an aws_prometheus_workspace, create a logging configuration if none existed previously

Relations

Closes #27472.
Closes #28664.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAMPWorkspace_' PKG=amp ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amp/... -v -count 1 -parallel 3  -run=TestAccAMPWorkspace_ -timeout 180m
=== RUN   TestAccAMPWorkspace_basic
=== PAUSE TestAccAMPWorkspace_basic
=== RUN   TestAccAMPWorkspace_disappears
=== PAUSE TestAccAMPWorkspace_disappears
=== RUN   TestAccAMPWorkspace_tags
=== PAUSE TestAccAMPWorkspace_tags
=== RUN   TestAccAMPWorkspace_alias
=== PAUSE TestAccAMPWorkspace_alias
=== RUN   TestAccAMPWorkspace_loggingConfiguration
=== PAUSE TestAccAMPWorkspace_loggingConfiguration
=== CONT  TestAccAMPWorkspace_basic
=== CONT  TestAccAMPWorkspace_alias
=== CONT  TestAccAMPWorkspace_loggingConfiguration
--- PASS: TestAccAMPWorkspace_basic (21.10s)
=== CONT  TestAccAMPWorkspace_tags
--- PASS: TestAccAMPWorkspace_alias (60.79s)
=== CONT  TestAccAMPWorkspace_disappears
--- PASS: TestAccAMPWorkspace_tags (45.14s)
--- PASS: TestAccAMPWorkspace_loggingConfiguration (66.24s)
--- PASS: TestAccAMPWorkspace_disappears (13.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amp	80.033s

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/amp Issues and PRs that pertain to the amp service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. labels Feb 3, 2023
@ewbankkit ewbankkit merged commit 04c159d into main Feb 3, 2023
@ewbankkit ewbankkit deleted the b-27472 branch February 3, 2023 18:27
@github-actions github-actions bot added this to the v4.54.0 milestone Feb 3, 2023
github-actions bot pushed a commit that referenced this pull request Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

This functionality has been released in v4.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/amp Issues and PRs that pertain to the amp service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't enable logging configuration for existing AWS Prometheus workspace
2 participants