Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add examples and AWS documentation to aws_opensearchserverless_access… #32571

Conversation

joshjluo
Copy link
Contributor

…_policy resource

Description

  • Adds additional examples on how to use the aws_opensearchserverless_access_policy resource
  • Links to AWS documentation as argument values are likely to update over time

Relations

N/A

References

Output from Acceptance Testing

N/A

Additional Testing

Verified the Terraform configurations were valid by applying terraform apply.

$ terraform apply

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # aws_opensearchserverless_access_policy.example1 will be created
...
  # aws_opensearchserverless_access_policy.example2 will be created
...
  # aws_opensearchserverless_access_policy.example3 will be created
...
Plan: 3 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

...

Apply complete! Resources: 3 added, 0 changed, 0 destroyed.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Jul 18, 2023
@joshjluo joshjluo changed the title Add examples and AWS documentation to aws_opensearchserverless_access… docs: Add examples and AWS documentation to aws_opensearchserverless_access… Jul 18, 2023
Copy link
Member

@justinretzolk justinretzolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for taking the time to raise this! I'll get this merged in once the checks finish up 🚀

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jul 24, 2023
@justinretzolk justinretzolk merged commit 2f0f9a6 into hashicorp:main Jul 24, 2023
44 checks passed
@github-actions github-actions bot added this to the v5.10.0 milestone Jul 24, 2023
@github-actions
Copy link

This functionality has been released in v5.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants