Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_quicksight_{analysis,dashboard}: flatten/expand theme_arn. #33582

Closed
wants to merge 2 commits into from

Conversation

gbw
Copy link
Contributor

@gbw gbw commented Sep 22, 2023

Description

Adds flatten/expand for theme_arn for resources aws_quicksight_analysis, aws_quicksight_dashboard.

Relations

Closes #33524

References

QuickSight Documentation

Output from Acceptance Testing

I lack permissions to test this.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/quicksight Issues and PRs that pertain to the quicksight service. labels Sep 22, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 22, 2023
@gbw gbw marked this pull request as ready for review September 22, 2023 07:54
@gbw
Copy link
Contributor Author

gbw commented Sep 23, 2023

Already done in PR #31737

@gbw gbw closed this Sep 23, 2023
@terraform-aws-provider terraform-aws-provider bot removed the needs-triage Waiting for first response or review from a maintainer. label Sep 23, 2023
@gbw gbw deleted the f-aws_quicksight_theme_arn branch October 21, 2023 23:00
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/quicksight Issues and PRs that pertain to the quicksight service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Terraform doesn't send themeArn field in API call when creating or updating aws_quicksight_analysis
1 participant