From 179b68091dfbd7242443db2940d7d931225f2f92 Mon Sep 17 00:00:00 2001 From: Albert Silva Date: Tue, 3 Oct 2023 13:26:12 -0400 Subject: [PATCH 1/4] set dns_record_type as computed --- internal/service/ec2/vpc_endpoint.go | 1 + 1 file changed, 1 insertion(+) diff --git a/internal/service/ec2/vpc_endpoint.go b/internal/service/ec2/vpc_endpoint.go index 8498dfd618d..73b451451d5 100644 --- a/internal/service/ec2/vpc_endpoint.go +++ b/internal/service/ec2/vpc_endpoint.go @@ -89,6 +89,7 @@ func ResourceVPCEndpoint() *schema.Resource { "dns_record_ip_type": { Type: schema.TypeString, Optional: true, + Computed: true, ValidateFunc: validation.StringInSlice(ec2.DnsRecordIpType_Values(), false), }, "private_dns_only_for_inbound_resolver_endpoint": { From abbc6549f3806d142fd1d1535a7a94fe96057ece Mon Sep 17 00:00:00 2001 From: Albert Silva Date: Tue, 3 Oct 2023 13:27:56 -0400 Subject: [PATCH 2/4] add changelog --- .changelog/33743.txt | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 .changelog/33743.txt diff --git a/.changelog/33743.txt b/.changelog/33743.txt new file mode 100644 index 00000000000..4249614ad71 --- /dev/null +++ b/.changelog/33743.txt @@ -0,0 +1,4 @@ + +```release-note:bug +resource/aws_vpc_endpoint: Set dns_record_ip_type to `Computed` to prevent diffs +``` \ No newline at end of file From d47947ba12b5fcdcca52a6cb64ded8ea59ea5443 Mon Sep 17 00:00:00 2001 From: Kit Ewbank Date: Wed, 4 Oct 2023 07:53:19 -0700 Subject: [PATCH 3/4] Update 33743.txt --- .changelog/33743.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.changelog/33743.txt b/.changelog/33743.txt index 4249614ad71..c7840ef6e9a 100644 --- a/.changelog/33743.txt +++ b/.changelog/33743.txt @@ -1,4 +1,4 @@ ```release-note:bug -resource/aws_vpc_endpoint: Set dns_record_ip_type to `Computed` to prevent diffs -``` \ No newline at end of file +resource/aws_vpc_endpoint: Set `dns_options.dns_record_ip_type` to `Computed` to prevent diffs +``` From a7c2ab2734f7626549c7767dc8da27f6fe726765 Mon Sep 17 00:00:00 2001 From: Kit Ewbank Date: Thu, 5 Oct 2023 07:32:52 -0700 Subject: [PATCH 4/4] Tweak 'TestAccVPCEndpoint_interfacePrivateDNS' for default value. --- internal/service/ec2/vpc_endpoint_test.go | 1 - 1 file changed, 1 deletion(-) diff --git a/internal/service/ec2/vpc_endpoint_test.go b/internal/service/ec2/vpc_endpoint_test.go index c7e1e5af4c4..b927fc8f8e6 100644 --- a/internal/service/ec2/vpc_endpoint_test.go +++ b/internal/service/ec2/vpc_endpoint_test.go @@ -809,7 +809,6 @@ resource "aws_vpc_endpoint" "test" { ip_address_type = "ipv4" dns_options { - dns_record_ip_type = "ipv4" private_dns_only_for_inbound_resolver_endpoint = %[2]t }