Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set basic_auth to optional in self_managed_kafka_parameters #34293

Merged
merged 5 commits into from
Jun 6, 2024
Merged

fix: Set basic_auth to optional in self_managed_kafka_parameters #34293

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b67be75
Set basic_auth to optional in self_managed_kafka_parameters
vzilinas Nov 7, 2023
c2ad22a
Add changelog
vzilinas Nov 7, 2023
f4b93ec
Merge branch 'main' into HEAD
ewbankkit Jun 6, 2024
6bdd253
Tweak CHANGELOG entry.
ewbankkit Jun 6, 2024
73c6e50
r/aws_pipes_pipe: Use 'SchemaFunc'.
ewbankkit Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/34293.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_pipes_pipe: Make self_managed_kafka_parameters.credentials.basic_auth Optional
```
2 changes: 1 addition & 1 deletion internal/service/pipes/source_parameters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ func sourceParametersSchema() *schema.Schema {
Schema: map[string]*schema.Schema{
"basic_auth": {
Type: schema.TypeString,
Required: true,
Optional: true,
vzilinas marked this conversation as resolved.
Show resolved Hide resolved
ValidateFunc: verifySecretsManagerARN,
},
"client_certificate_tls_auth": {
Expand Down