r/aws_dms_replication_config: Add missing task settings

[nam054]

Description

DMS replication config would show non-zero value defaults were being removed from the plan. This PR creates a defaults map in task_settings_json to compare with what's being configured to make sure that if the settings are set to default, the diffs would be suppressed.

Relations

Closes #35573

References

Output from Acceptance Testing

> make testacc TESTARGS='-run=TestAccDMSReplicationConfig_' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSReplicationConfig_ -timeout 360m
=== RUN   TestAccDMSReplicationConfig_basic
=== PAUSE TestAccDMSReplicationConfig_basic
=== RUN   TestAccDMSReplicationConfig_noChangeOnDefault
=== PAUSE TestAccDMSReplicationConfig_noChangeOnDefault
=== RUN   TestAccDMSReplicationConfig_disappears
=== PAUSE TestAccDMSReplicationConfig_disappears
=== RUN   TestAccDMSReplicationConfig_tags
=== PAUSE TestAccDMSReplicationConfig_tags
=== RUN   TestAccDMSReplicationConfig_update
=== PAUSE TestAccDMSReplicationConfig_update
=== RUN   TestAccDMSReplicationConfig_startReplication
=== PAUSE TestAccDMSReplicationConfig_startReplication
=== CONT  TestAccDMSReplicationConfig_basic
=== CONT  TestAccDMSReplicationConfig_tags
=== CONT  TestAccDMSReplicationConfig_update
=== CONT  TestAccDMSReplicationConfig_disappears
=== CONT  TestAccDMSReplicationConfig_noChangeOnDefault
=== CONT  TestAccDMSReplicationConfig_startReplication
--- PASS: TestAccDMSReplicationConfig_basic (1500.92s)
--- PASS: TestAccDMSReplicationConfig_noChangeOnDefault (1503.27s)
--- PASS: TestAccDMSReplicationConfig_disappears (1529.48s)
--- PASS: TestAccDMSReplicationConfig_update (1563.68s)
--- PASS: TestAccDMSReplicationConfig_tags (1628.00s)
--- PASS: TestAccDMSReplicationConfig_startReplication (3272.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        3276.416s

> make testacc TESTARGS='-run=TestAccDMSReplicationTask_' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSReplicationTask_ -timeout 360m
=== RUN   TestAccDMSReplicationTask_basic
=== PAUSE TestAccDMSReplicationTask_basic
=== RUN   TestAccDMSReplicationTask_update
=== PAUSE TestAccDMSReplicationTask_update
=== RUN   TestAccDMSReplicationTask_cdcStartPosition
=== PAUSE TestAccDMSReplicationTask_cdcStartPosition
=== RUN   TestAccDMSReplicationTask_startReplicationTask
=== PAUSE TestAccDMSReplicationTask_startReplicationTask
=== RUN   TestAccDMSReplicationTask_s3ToRDS
=== PAUSE TestAccDMSReplicationTask_s3ToRDS
=== RUN   TestAccDMSReplicationTask_disappears
=== PAUSE TestAccDMSReplicationTask_disappears
=== RUN   TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
=== PAUSE TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
=== RUN   TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
=== PAUSE TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
=== RUN   TestAccDMSReplicationTask_move
=== PAUSE TestAccDMSReplicationTask_move
=== CONT  TestAccDMSReplicationTask_basic
=== CONT  TestAccDMSReplicationTask_disappears
=== CONT  TestAccDMSReplicationTask_startReplicationTask
=== CONT  TestAccDMSReplicationTask_cdcStartPosition
=== CONT  TestAccDMSReplicationTask_update
=== CONT  TestAccDMSReplicationTask_s3ToRDS
=== CONT  TestAccDMSReplicationTask_cdcStartTime_unix_timestamp
=== CONT  TestAccDMSReplicationTask_cdcStartTime_rfc3339_date
=== CONT  TestAccDMSReplicationTask_move
--- PASS: TestAccDMSReplicationTask_cdcStartPosition (928.24s)
--- PASS: TestAccDMSReplicationTask_cdcStartTime_unix_timestamp (928.53s)
--- PASS: TestAccDMSReplicationTask_disappears (947.10s)
--- PASS: TestAccDMSReplicationTask_basic (987.13s)
--- PASS: TestAccDMSReplicationTask_move (1235.57s)
--- PASS: TestAccDMSReplicationTask_cdcStartTime_rfc3339_date (1339.97s)
--- PASS: TestAccDMSReplicationTask_s3ToRDS (1566.27s)
--- PASS: TestAccDMSReplicationTask_update (1596.19s)
--- PASS: TestAccDMSReplicationTask_startReplicationTask (2057.24s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        2061.873s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

[johnsonaj]

LGTM 🚀

make testacc TESTARGS='-run=TestAccDMSReplicationTask_\|TestAccDMSReplicationConfig_' PKG=dms | filter-test                                                                                               141 ↵
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSReplicationTask_\|TestAccDMSReplicationConfig_ -timeout 360m
--- PASS: TestAccDMSReplicationTask_cdcStartTime_rfc3339_date (952.98s)
--- PASS: TestAccDMSReplicationTask_disappears (961.52s)
--- PASS: TestAccDMSReplicationTask_cdcStartTime_unix_timestamp (973.39s)
--- PASS: TestAccDMSReplicationTask_cdcStartPosition (996.06s)
--- PASS: TestAccDMSReplicationTask_basic (1020.76s)
--- PASS: TestAccDMSReplicationConfig_tags (1364.17s)
--- PASS: TestAccDMSReplicationConfig_update (1404.11s)
--- PASS: TestAccDMSReplicationConfig_basic (1505.28s)
--- PASS: TestAccDMSReplicationConfig_noChangeOnDefault (1525.73s)
--- PASS: TestAccDMSReplicationConfig_disappears (1584.93s)
--- PASS: TestAccDMSReplicationTask_update (1596.88s)
--- PASS: TestAccDMSReplicationTask_s3ToRDS (1713.89s)
--- PASS: TestAccDMSReplicationTask_move (1787.15s)
--- PASS: TestAccDMSReplicationTask_startReplicationTask (1854.96s)
--- PASS: TestAccDMSReplicationConfig_startReplication (3131.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	3136.463s

[johnsonaj]

@nam054 needs CHANGELOG entry

[github-actions]

This functionality has been released in v5.42.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.