Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mark name arg as optional to match AWS API for aws_ram_resource_share data source #36062

Commits on Mar 4, 2024

  1. Configuration menu
    Copy the full SHA
    39b240b View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Configuration menu
    Copy the full SHA
    5523c20 View commit details
    Browse the repository at this point in the history
  2. Tweak CHANGELOG entry.

    ewbankkit committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    6653ae0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    af04347 View commit details
    Browse the repository at this point in the history
  4. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccRAMResourceShareDataSource_' PKG=ram ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.21.8 test ./internal/service/ram/... -v -count 1 -parallel 2  -run=TestAccRAMResourceShareDataSource_ -timeout 360m
    === RUN   TestAccRAMResourceShareDataSource_basic
    === PAUSE TestAccRAMResourceShareDataSource_basic
    === RUN   TestAccRAMResourceShareDataSource_tags
    === PAUSE TestAccRAMResourceShareDataSource_tags
    === RUN   TestAccRAMResourceShareDataSource_resources
    === PAUSE TestAccRAMResourceShareDataSource_resources
    === RUN   TestAccRAMResourceShareDataSource_status
    === PAUSE TestAccRAMResourceShareDataSource_status
    === CONT  TestAccRAMResourceShareDataSource_basic
    === CONT  TestAccRAMResourceShareDataSource_resources
    --- PASS: TestAccRAMResourceShareDataSource_basic (22.08s)
    === CONT  TestAccRAMResourceShareDataSource_status
    --- PASS: TestAccRAMResourceShareDataSource_resources (31.19s)
    === CONT  TestAccRAMResourceShareDataSource_tags
    --- PASS: TestAccRAMResourceShareDataSource_status (20.36s)
    --- PASS: TestAccRAMResourceShareDataSource_tags (33.33s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ram	71.779s
    ewbankkit committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    96179e5 View commit details
    Browse the repository at this point in the history
  5. ram: Reduce visibility.

    ewbankkit committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f052992 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    acdbe8c View commit details
    Browse the repository at this point in the history
  7. Cosmetics.

    ewbankkit committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    240bde8 View commit details
    Browse the repository at this point in the history
  8. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccRAMSharingWithOrganization_serial' PKG=ram ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.21.8 test ./internal/service/ram/... -v -count 1 -parallel 2  -run=TestAccRAMSharingWithOrganization_serial -timeout 360m
    === RUN   TestAccRAMSharingWithOrganization_serial
    === PAUSE TestAccRAMSharingWithOrganization_serial
    === CONT  TestAccRAMSharingWithOrganization_serial
    === RUN   TestAccRAMSharingWithOrganization_serial/basic
    === RUN   TestAccRAMSharingWithOrganization_serial/disappears
    --- PASS: TestAccRAMSharingWithOrganization_serial (62.85s)
        --- PASS: TestAccRAMSharingWithOrganization_serial/basic (33.02s)
        --- PASS: TestAccRAMSharingWithOrganization_serial/disappears (29.83s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ram	69.848s
    ewbankkit committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f7b5296 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2e4c9ea View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    96c9319 View commit details
    Browse the repository at this point in the history
  11. ram: Add 'consts.go'.

    ewbankkit committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    b13dd48 View commit details
    Browse the repository at this point in the history
  12. Add 'option.Unwrap'.

    ewbankkit committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    e8f0f2c View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    bc75b04 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b14050c View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    33bd11a View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    e084a82 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Configuration menu
    Copy the full SHA
    f3cc15f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    642077d View commit details
    Browse the repository at this point in the history
  3. Add 'IsAWSAccountID'.

    ewbankkit committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f68d43c View commit details
    Browse the repository at this point in the history
  4. Use 'IsAWSAccountID'.

    ewbankkit committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    df6bb85 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d99ba73 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4085948 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1002297 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    857044b View commit details
    Browse the repository at this point in the history
  9. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccRAMPrincipalAssociation_duplicate' PKG=ram ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.21.8 test ./internal/service/ram/... -v -count 1 -parallel 2  -run=TestAccRAMPrincipalAssociation_duplicate -timeout 360m
    === RUN   TestAccRAMPrincipalAssociation_duplicate
    === PAUSE TestAccRAMPrincipalAssociation_duplicate
    === CONT  TestAccRAMPrincipalAssociation_duplicate
    --- PASS: TestAccRAMPrincipalAssociation_duplicate (28.71s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ram	35.841s
    ewbankkit committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f743ef8 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5c33065 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    47b1a1b View commit details
    Browse the repository at this point in the history
  12. Acceptance test output:

    % make testacc TESTARGS='-run=TestAccRAMResourceAssociation_duplicate' PKG=ram ACCTEST_PARALLELISM=2
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.21.8 test ./internal/service/ram/... -v -count 1 -parallel 2  -run=TestAccRAMResourceAssociation_duplicate -timeout 360m
    === RUN   TestAccRAMResourceAssociation_duplicate
    === PAUSE TestAccRAMResourceAssociation_duplicate
    === CONT  TestAccRAMResourceAssociation_duplicate
    --- PASS: TestAccRAMResourceAssociation_duplicate (27.12s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ram	34.588s
    ewbankkit committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    cc36db5 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    c1b883d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    56129a9 View commit details
    Browse the repository at this point in the history