-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Mark name arg as optional to match AWS API for aws_ram_resource_share data source #36062
Merged
ewbankkit
merged 31 commits into
hashicorp:main
from
acwwat:f-aws_ram_resource_share-data_source_name_optional
Mar 14, 2024
Merged
feat: Mark name arg as optional to match AWS API for aws_ram_resource_share data source #36062
ewbankkit
merged 31 commits into
hashicorp:main
from
acwwat:f-aws_ram_resource_share-data_source_name_optional
Mar 14, 2024
Commits on Mar 4, 2024
-
feat: Mark name arg as optional to match AWS API for aws_ram_resource…
…_share data source
Configuration menu - View commit details
-
Copy full SHA for 39b240b - Browse repository at this point
Copy the full SHA 39b240bView commit details
Commits on Mar 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5523c20 - Browse repository at this point
Copy the full SHA 5523c20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6653ae0 - Browse repository at this point
Copy the full SHA 6653ae0View commit details -
Configuration menu - View commit details
-
Copy full SHA for af04347 - Browse repository at this point
Copy the full SHA af04347View commit details -
% make testacc TESTARGS='-run=TestAccRAMResourceShareDataSource_' PKG=ram ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/ram/... -v -count 1 -parallel 2 -run=TestAccRAMResourceShareDataSource_ -timeout 360m === RUN TestAccRAMResourceShareDataSource_basic === PAUSE TestAccRAMResourceShareDataSource_basic === RUN TestAccRAMResourceShareDataSource_tags === PAUSE TestAccRAMResourceShareDataSource_tags === RUN TestAccRAMResourceShareDataSource_resources === PAUSE TestAccRAMResourceShareDataSource_resources === RUN TestAccRAMResourceShareDataSource_status === PAUSE TestAccRAMResourceShareDataSource_status === CONT TestAccRAMResourceShareDataSource_basic === CONT TestAccRAMResourceShareDataSource_resources --- PASS: TestAccRAMResourceShareDataSource_basic (22.08s) === CONT TestAccRAMResourceShareDataSource_status --- PASS: TestAccRAMResourceShareDataSource_resources (31.19s) === CONT TestAccRAMResourceShareDataSource_tags --- PASS: TestAccRAMResourceShareDataSource_status (20.36s) --- PASS: TestAccRAMResourceShareDataSource_tags (33.33s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ram 71.779s
Configuration menu - View commit details
-
Copy full SHA for 96179e5 - Browse repository at this point
Copy the full SHA 96179e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f052992 - Browse repository at this point
Copy the full SHA f052992View commit details -
Configuration menu - View commit details
-
Copy full SHA for acdbe8c - Browse repository at this point
Copy the full SHA acdbe8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 240bde8 - Browse repository at this point
Copy the full SHA 240bde8View commit details -
% make testacc TESTARGS='-run=TestAccRAMSharingWithOrganization_serial' PKG=ram ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/ram/... -v -count 1 -parallel 2 -run=TestAccRAMSharingWithOrganization_serial -timeout 360m === RUN TestAccRAMSharingWithOrganization_serial === PAUSE TestAccRAMSharingWithOrganization_serial === CONT TestAccRAMSharingWithOrganization_serial === RUN TestAccRAMSharingWithOrganization_serial/basic === RUN TestAccRAMSharingWithOrganization_serial/disappears --- PASS: TestAccRAMSharingWithOrganization_serial (62.85s) --- PASS: TestAccRAMSharingWithOrganization_serial/basic (33.02s) --- PASS: TestAccRAMSharingWithOrganization_serial/disappears (29.83s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ram 69.848s
Configuration menu - View commit details
-
Copy full SHA for f7b5296 - Browse repository at this point
Copy the full SHA f7b5296View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e4c9ea - Browse repository at this point
Copy the full SHA 2e4c9eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96c9319 - Browse repository at this point
Copy the full SHA 96c9319View commit details -
Configuration menu - View commit details
-
Copy full SHA for b13dd48 - Browse repository at this point
Copy the full SHA b13dd48View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8f0f2c - Browse repository at this point
Copy the full SHA e8f0f2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc75b04 - Browse repository at this point
Copy the full SHA bc75b04View commit details -
Configuration menu - View commit details
-
Copy full SHA for b14050c - Browse repository at this point
Copy the full SHA b14050cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 33bd11a - Browse repository at this point
Copy the full SHA 33bd11aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e084a82 - Browse repository at this point
Copy the full SHA e084a82View commit details
Commits on Mar 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f3cc15f - Browse repository at this point
Copy the full SHA f3cc15fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 642077d - Browse repository at this point
Copy the full SHA 642077dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f68d43c - Browse repository at this point
Copy the full SHA f68d43cView commit details -
Configuration menu - View commit details
-
Copy full SHA for df6bb85 - Browse repository at this point
Copy the full SHA df6bb85View commit details -
Configuration menu - View commit details
-
Copy full SHA for d99ba73 - Browse repository at this point
Copy the full SHA d99ba73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4085948 - Browse repository at this point
Copy the full SHA 4085948View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1002297 - Browse repository at this point
Copy the full SHA 1002297View commit details -
Configuration menu - View commit details
-
Copy full SHA for 857044b - Browse repository at this point
Copy the full SHA 857044bView commit details -
% make testacc TESTARGS='-run=TestAccRAMPrincipalAssociation_duplicate' PKG=ram ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/ram/... -v -count 1 -parallel 2 -run=TestAccRAMPrincipalAssociation_duplicate -timeout 360m === RUN TestAccRAMPrincipalAssociation_duplicate === PAUSE TestAccRAMPrincipalAssociation_duplicate === CONT TestAccRAMPrincipalAssociation_duplicate --- PASS: TestAccRAMPrincipalAssociation_duplicate (28.71s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ram 35.841s
Configuration menu - View commit details
-
Copy full SHA for f743ef8 - Browse repository at this point
Copy the full SHA f743ef8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c33065 - Browse repository at this point
Copy the full SHA 5c33065View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47b1a1b - Browse repository at this point
Copy the full SHA 47b1a1bView commit details -
% make testacc TESTARGS='-run=TestAccRAMResourceAssociation_duplicate' PKG=ram ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.21.8 test ./internal/service/ram/... -v -count 1 -parallel 2 -run=TestAccRAMResourceAssociation_duplicate -timeout 360m === RUN TestAccRAMResourceAssociation_duplicate === PAUSE TestAccRAMResourceAssociation_duplicate === CONT TestAccRAMResourceAssociation_duplicate --- PASS: TestAccRAMResourceAssociation_duplicate (27.12s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ram 34.588s
Configuration menu - View commit details
-
Copy full SHA for cc36db5 - Browse repository at this point
Copy the full SHA cc36db5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1b883d - Browse repository at this point
Copy the full SHA c1b883dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56129a9 - Browse repository at this point
Copy the full SHA 56129a9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.