r/aws_m2_deployment: set deployment_id on start/stop

[johnsonaj]

Description

Before:

% make testacc TESTARGS="-run=TestAccM2Deployment_start" PKG=m2

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/m2/... -v -count 1 -parallel 20  -run=TestAccM2Deployment_nostart -timeout 360m
=== RUN   TestAccM2Deployment_start
=== PAUSE TestAccM2Deployment_start
=== CONT  TestAccM2Deployment_start
    deployment_test.go:97: Step 3/3 error: Error running apply: exit status 1

        Error: Provider returned invalid result object after apply

        After the apply operation, the provider still indicated an unknown value for
        aws_m2_deployment.test.deployment_id. All values must be known after apply,
        so this is always a bug in the provider and should be reported in the
        provider's own repository. Terraform will still save the other known object
        values in the state.
    panic.go:626: Error running post-test destroy, there may be dangling resources: operation error m2: GetDeployment, serialization failed: serialization failed: input member deploymentId must not be empty
--- FAIL: TestAccM2Deployment_nostart (2831.37s)
FAIL
FAIL	[github.com/hashicorp/terraform-provider-aws/internal/service/m2](http://github.com/hashicorp/terraform-provider-aws/internal/service/m2)	2836.723s
FAIL
make: *** [testacc] Error 1

Relations

References

Output from Acceptance Testing

After:

% make testacc TESTARGS="-run=TestAccM2Deployment_" PKG=m2

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/m2/... -v -count 1 -parallel 20  -run=TestAccM2Deployment_ -timeout 360m
--- PASS: TestAccM2Deployment_start (2868.05s)
--- PASS: TestAccM2Deployment_disappears (2919.10s)
--- PASS: TestAccM2Deployment_basic (2997.56s)
--- PASS: TestAccM2Deployment_update (3291.45s)
PASS
ok  	[github.com/hashicorp/terraform-provider-aws/internal/service/m2](http://github.com/hashicorp/terraform-provider-aws/internal/service/m2)	3296.872s
--- PASS: TestAccAppStreamDirectoryConfig_basic (3851.45s)
PASS
ok  	[github.com/hashicorp/terraform-provider-aws/internal/service/appstream](http://github.com/hashicorp/terraform-provider-aws/internal/service/appstream)	3856.704s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.