Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamelift: Migrate to AWS SDK v2 #38379

Merged
merged 33 commits into from
Aug 9, 2024

Conversation

mattburgess
Copy link
Collaborator

@mattburgess mattburgess commented Jul 15, 2024

Description

Relations

Closes #36164
Relates #32976

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@mattburgess mattburgess added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Jul 15, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/gamelift Issues and PRs that pertain to the gamelift service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Jul 15, 2024
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@mattburgess mattburgess marked this pull request as ready for review July 16, 2024 19:52
@mattburgess mattburgess requested a review from a team as a code owner July 16, 2024 19:52
@justinretzolk justinretzolk added the external-maintainer Contribution from a trusted external contributor. label Jul 29, 2024
# Conflicts:
#	go.mod
#	go.sum
#	internal/conns/awsclient_gen.go
#	internal/service/ecs/cluster.go
#	internal/service/ecs/cluster_test.go
#	names/names.go
#	website/docs/r/ecs_cluster.html.markdown
@ewbankkit ewbankkit self-assigned this Aug 8, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 8, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccGameLift' PKG=gamelift ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/gamelift/... -v -count 1 -parallel 3  -run=TestAccGameLift -timeout 720m
=== RUN   TestAccGameLiftAlias_basic
=== PAUSE TestAccGameLiftAlias_basic
=== RUN   TestAccGameLiftAlias_tags
=== PAUSE TestAccGameLiftAlias_tags
=== RUN   TestAccGameLiftAlias_fleetRouting
=== PAUSE TestAccGameLiftAlias_fleetRouting
=== RUN   TestAccGameLiftAlias_disappears
=== PAUSE TestAccGameLiftAlias_disappears
=== RUN   TestAccGameLiftBuild_basic
=== PAUSE TestAccGameLiftBuild_basic
=== RUN   TestAccGameLiftBuild_tags
=== PAUSE TestAccGameLiftBuild_tags
=== RUN   TestAccGameLiftBuild_disappears
=== PAUSE TestAccGameLiftBuild_disappears
=== RUN   TestAccGameLiftFleet_basic
=== PAUSE TestAccGameLiftFleet_basic
=== RUN   TestAccGameLiftFleet_tags
=== PAUSE TestAccGameLiftFleet_tags
=== RUN   TestAccGameLiftFleet_allFields
=== PAUSE TestAccGameLiftFleet_allFields
=== RUN   TestAccGameLiftFleet_cert
=== PAUSE TestAccGameLiftFleet_cert
=== RUN   TestAccGameLiftFleet_script
=== PAUSE TestAccGameLiftFleet_script
=== RUN   TestAccGameLiftFleet_disappears
=== PAUSE TestAccGameLiftFleet_disappears
=== RUN   TestAccGameLiftGameServerGroup_basic
=== PAUSE TestAccGameLiftGameServerGroup_basic
=== RUN   TestAccGameLiftGameServerGroup_AutoScalingPolicy
=== PAUSE TestAccGameLiftGameServerGroup_AutoScalingPolicy
=== RUN   TestAccGameLiftGameServerGroup_AutoScalingPolicy_EstimatedInstanceWarmup
=== PAUSE TestAccGameLiftGameServerGroup_AutoScalingPolicy_EstimatedInstanceWarmup
=== RUN   TestAccGameLiftGameServerGroup_BalancingStrategy
=== PAUSE TestAccGameLiftGameServerGroup_BalancingStrategy
=== RUN   TestAccGameLiftGameServerGroup_GameServerGroupName
=== PAUSE TestAccGameLiftGameServerGroup_GameServerGroupName
=== RUN   TestAccGameLiftGameServerGroup_InstanceDefinition
=== PAUSE TestAccGameLiftGameServerGroup_InstanceDefinition
=== RUN   TestAccGameLiftGameServerGroup_InstanceDefinition_WeightedCapacity
=== PAUSE TestAccGameLiftGameServerGroup_InstanceDefinition_WeightedCapacity
=== RUN   TestAccGameLiftGameServerGroup_LaunchTemplate_Id
=== PAUSE TestAccGameLiftGameServerGroup_LaunchTemplate_Id
=== RUN   TestAccGameLiftGameServerGroup_LaunchTemplate_Name
=== PAUSE TestAccGameLiftGameServerGroup_LaunchTemplate_Name
=== RUN   TestAccGameLiftGameServerGroup_LaunchTemplate_Version
=== PAUSE TestAccGameLiftGameServerGroup_LaunchTemplate_Version
=== RUN   TestAccGameLiftGameServerGroup_GameServerProtectionPolicy
=== PAUSE TestAccGameLiftGameServerGroup_GameServerProtectionPolicy
=== RUN   TestAccGameLiftGameServerGroup_MaxSize
=== PAUSE TestAccGameLiftGameServerGroup_MaxSize
=== RUN   TestAccGameLiftGameServerGroup_MinSize
=== PAUSE TestAccGameLiftGameServerGroup_MinSize
=== RUN   TestAccGameLiftGameServerGroup_roleARN
=== PAUSE TestAccGameLiftGameServerGroup_roleARN
=== RUN   TestAccGameLiftGameServerGroup_vpcSubnets
=== PAUSE TestAccGameLiftGameServerGroup_vpcSubnets
=== RUN   TestAccGameLiftGameSessionQueue_basic
--- PASS: TestAccGameLiftGameSessionQueue_basic (20.08s)
=== RUN   TestAccGameLiftGameSessionQueue_tags
--- PASS: TestAccGameLiftGameSessionQueue_tags (26.72s)
=== RUN   TestAccGameLiftGameSessionQueue_disappears
--- PASS: TestAccGameLiftGameSessionQueue_disappears (9.90s)
=== RUN   TestAccGameLiftScript_basic
=== PAUSE TestAccGameLiftScript_basic
=== RUN   TestAccGameLiftScript_tags
=== PAUSE TestAccGameLiftScript_tags
=== RUN   TestAccGameLiftScript_disappears
=== PAUSE TestAccGameLiftScript_disappears
=== CONT  TestAccGameLiftAlias_basic
=== CONT  TestAccGameLiftGameServerGroup_BalancingStrategy
=== CONT  TestAccGameLiftGameServerGroup_MaxSize
--- PASS: TestAccGameLiftAlias_basic (18.52s)
=== CONT  TestAccGameLiftScript_basic
--- PASS: TestAccGameLiftScript_basic (17.93s)
=== CONT  TestAccGameLiftScript_disappears
--- PASS: TestAccGameLiftScript_disappears (10.03s)
=== CONT  TestAccGameLiftScript_tags
--- PASS: TestAccGameLiftScript_tags (25.85s)
=== CONT  TestAccGameLiftGameServerGroup_LaunchTemplate_Id
--- PASS: TestAccGameLiftGameServerGroup_BalancingStrategy (253.81s)
=== CONT  TestAccGameLiftGameServerGroup_GameServerProtectionPolicy
--- PASS: TestAccGameLiftGameServerGroup_MaxSize (297.67s)
=== CONT  TestAccGameLiftGameServerGroup_LaunchTemplate_Version
--- PASS: TestAccGameLiftGameServerGroup_LaunchTemplate_Id (236.87s)
=== CONT  TestAccGameLiftGameServerGroup_InstanceDefinition
--- PASS: TestAccGameLiftGameServerGroup_GameServerProtectionPolicy (222.25s)
=== CONT  TestAccGameLiftGameServerGroup_LaunchTemplate_Name
--- PASS: TestAccGameLiftGameServerGroup_LaunchTemplate_Version (219.89s)
=== CONT  TestAccGameLiftGameServerGroup_InstanceDefinition_WeightedCapacity
--- PASS: TestAccGameLiftGameServerGroup_InstanceDefinition (208.43s)
=== CONT  TestAccGameLiftGameServerGroup_GameServerGroupName
--- PASS: TestAccGameLiftGameServerGroup_LaunchTemplate_Name (196.20s)
=== CONT  TestAccGameLiftGameServerGroup_roleARN
--- PASS: TestAccGameLiftGameServerGroup_InstanceDefinition_WeightedCapacity (215.13s)
=== CONT  TestAccGameLiftGameServerGroup_MinSize
--- PASS: TestAccGameLiftGameServerGroup_GameServerGroupName (381.02s)
=== CONT  TestAccGameLiftGameServerGroup_vpcSubnets
--- PASS: TestAccGameLiftGameServerGroup_roleARN (339.80s)
=== CONT  TestAccGameLiftBuild_disappears
--- PASS: TestAccGameLiftBuild_disappears (9.84s)
=== CONT  TestAccGameLiftFleet_tags
--- PASS: TestAccGameLiftGameServerGroup_MinSize (443.12s)
=== CONT  TestAccGameLiftBuild_basic
--- PASS: TestAccGameLiftBuild_basic (19.17s)
=== CONT  TestAccGameLiftGameServerGroup_AutoScalingPolicy_EstimatedInstanceWarmup
--- PASS: TestAccGameLiftGameServerGroup_AutoScalingPolicy_EstimatedInstanceWarmup (238.64s)
=== CONT  TestAccGameLiftGameServerGroup_AutoScalingPolicy
--- PASS: TestAccGameLiftGameServerGroup_vpcSubnets (569.56s)
=== CONT  TestAccGameLiftFleet_basic
--- PASS: TestAccGameLiftGameServerGroup_AutoScalingPolicy (233.13s)
=== CONT  TestAccGameLiftBuild_tags
--- PASS: TestAccGameLiftBuild_tags (25.72s)
=== CONT  TestAccGameLiftFleet_disappears
--- PASS: TestAccGameLiftFleet_tags (2074.16s)
=== CONT  TestAccGameLiftGameServerGroup_basic
--- PASS: TestAccGameLiftGameServerGroup_basic (169.23s)
=== CONT  TestAccGameLiftAlias_fleetRouting
--- PASS: TestAccGameLiftFleet_basic (1897.86s)
=== CONT  TestAccGameLiftFleet_allFields
--- PASS: TestAccGameLiftFleet_disappears (2002.77s)
=== CONT  TestAccGameLiftAlias_disappears
--- PASS: TestAccGameLiftAlias_disappears (9.41s)
=== CONT  TestAccGameLiftAlias_tags
--- PASS: TestAccGameLiftAlias_tags (26.25s)
=== CONT  TestAccGameLiftFleet_cert
--- PASS: TestAccGameLiftAlias_fleetRouting (2212.41s)
=== CONT  TestAccGameLiftFleet_script
--- PASS: TestAccGameLiftFleet_cert (2349.35s)
--- PASS: TestAccGameLiftFleet_script (1285.02s)
--- PASS: TestAccGameLiftFleet_allFields (4240.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/gamelift	7666.062s

@ewbankkit ewbankkit merged commit 84fec77 into hashicorp:main Aug 9, 2024
42 checks passed
@github-actions github-actions bot added this to the v5.63.0 milestone Aug 9, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 15, 2024
Copy link

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/gamelift Issues and PRs that pertain to the gamelift service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] GameLift Service
4 participants