Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_ecr_repository_creation_template: New resource. #38597

Merged
merged 5 commits into from
Jul 31, 2024
Merged

r/aws_ecr_repository_creation_template: New resource. #38597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5232328
r/aws_ecr_repository_creation_template: New resource.
bodgit Jul 30, 2024
8acc191
d/aws_ecr_repository_creation_template: New data source.
bodgit Jul 31, 2024
5a1cdaa
Add CHANGELOG entry.
ewbankkit Jul 31, 2024
b60584d
r/aws_ecr_repository_creation_template: Cosmetics.
ewbankkit Jul 31, 2024
f32b92b
d/aws_ecr_repository_creation_template: Cosmetics.
ewbankkit Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changelog/38597.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
```release-note:new-resource
aws_ecr_repository_creation_template
```

```release-note:new-data-source
aws_ecr_repository_creation_template
```
1 change: 1 addition & 0 deletions .ci/.semgrep-service-name1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1772,6 +1772,7 @@ rules:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)ECR"
- pattern-not-regex: "TemplateCreate"
- focus-metavariable: $NAME
- pattern-not: func $NAME($T *testing.T)
severity: WARNING
Expand Down
3 changes: 3 additions & 0 deletions internal/generate/servicesemgrep/service.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
{{- if eq .ServiceAlias "CloudTrail" }}
- pattern-not-regex: ^testAccCloudTrailConfig_.*
{{- end }}
{{- if eq .ServiceAlias "ECR" }}
- pattern-not-regex: "TemplateCreate"
{{- end }}
{{- if eq .ServiceAlias "Pipes" }}
- pattern-not-regex: ^.+Pipe[sS].*$
{{- end }}
Expand Down
16 changes: 9 additions & 7 deletions internal/service/ecr/exports_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@ var (
ResourceRegistryScanningConfiguration = resourceRegistryScanningConfiguration
ResourceReplicationConfiguration = resourceReplicationConfiguration
ResourceRepository = resourceRepository
ResourceRepositoryCreationTemplate = resourceRepositoryCreationTemplate
ResourceRepositoryPolicy = resourceRepositoryPolicy

FindLifecyclePolicyByRepositoryName = findLifecyclePolicyByRepositoryName
FindPullThroughCacheRuleByRepositoryPrefix = findPullThroughCacheRuleByRepositoryPrefix
FindRegistryPolicy = findRegistryPolicy
FindRegistryScanningConfiguration = findRegistryScanningConfiguration
FindReplicationConfiguration = findReplicationConfiguration
FindRepositoryByName = findRepositoryByName
FindRepositoryPolicyByRepositoryName = findRepositoryPolicyByRepositoryName
FindLifecyclePolicyByRepositoryName = findLifecyclePolicyByRepositoryName
FindPullThroughCacheRuleByRepositoryPrefix = findPullThroughCacheRuleByRepositoryPrefix
FindRegistryPolicy = findRegistryPolicy
FindRegistryScanningConfiguration = findRegistryScanningConfiguration
FindReplicationConfiguration = findReplicationConfiguration
FindRepositoryByName = findRepositoryByName
FindRepositoryCreationTemplateByRepositoryPrefix = findRepositoryCreationTemplateByRepositoryPrefix
FindRepositoryPolicyByRepositoryName = findRepositoryPolicyByRepositoryName
)
Loading
Loading