Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F aws chatbot slack channel configuration #38615

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

madhavvishnubhatta
Copy link
Contributor

Description

Adds a new resource SlackChannelConfiguration

Relations

Relates #12304
Closes #37222

References

https://docs.aws.amazon.com/chatbot/latest/APIReference/API_CreateSlackChannelConfiguration.html
https://docs.aws.amazon.com/chatbot/latest/APIReference/API_UpdateSlackChannelConfiguration.html
https://docs.aws.amazon.com/chatbot/latest/APIReference/API_DescribeSlackChannelConfigurations.html
https://docs.aws.amazon.com/chatbot/latest/APIReference/API_DeleteSlackChannelConfiguration.html

Output from Acceptance Testing

make testacc PKG=chatbot TESTS=TestAccChatbotSlackChannelConfiguration*
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/chatbot/... -v -count 1 -parallel 20 -run='TestAccChatbotSlackChannelConfiguration*'  -timeout 360m
=== RUN   TestAccChatbotSlackChannelConfiguration_basic
--- PASS: TestAccChatbotSlackChannelConfiguration_basic (28.07s)
=== RUN   TestAccChatbotSlackChannelConfiguration_all
--- PASS: TestAccChatbotSlackChannelConfiguration_all (38.83s)
=== RUN   TestAccChatbotSlackChannelConfiguration_guardrailPolicyArns
--- PASS: TestAccChatbotSlackChannelConfiguration_guardrailPolicyArns (36.27s)
=== RUN   TestAccChatbotSlackChannelConfiguration_iamRoleArn
--- PASS: TestAccChatbotSlackChannelConfiguration_iamRoleArn (35.69s)
=== RUN   TestAccChatbotSlackChannelConfiguration_loggingLevel
--- PASS: TestAccChatbotSlackChannelConfiguration_loggingLevel (39.24s)
=== RUN   TestAccChatbotSlackChannelConfiguration_slackChannelName
--- PASS: TestAccChatbotSlackChannelConfiguration_slackChannelName (35.55s)
=== RUN   TestAccChatbotSlackChannelConfiguration_userAuthorizationRequired
--- PASS: TestAccChatbotSlackChannelConfiguration_userAuthorizationRequired (34.79s)
=== RUN   TestAccChatbotSlackChannelConfiguration_disappears
=== PAUSE TestAccChatbotSlackChannelConfiguration_disappears
=== RUN   TestAccChatbotSlackChannelConfiguration_snsTopicArns
--- PASS: TestAccChatbotSlackChannelConfiguration_snsTopicArns (37.77s)
=== RUN   TestAccChatbotSlackChannelConfiguration_tags
--- PASS: TestAccChatbotSlackChannelConfiguration_tags (47.16s)
=== CONT  TestAccChatbotSlackChannelConfiguration_disappears
--- PASS: TestAccChatbotSlackChannelConfiguration_disappears (18.29s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/chatbot    357.899s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. generators Relates to code generators. service/chatbot Issues and PRs that pertain to the chatbot service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Jul 31, 2024
@justinretzolk justinretzolk added the new-resource Introduces a new resource. label Jul 31, 2024
@YakDriver
Copy link
Member

@madhavvishnubhatta Thank you for your work on this! I appreciate your contributions.

It looks like this PR and #38124 crossed paths. However, your tests are better. Please add them to the codebase.

As maintainers, Slack (#38124) and Teams channel configurations (#38630) are the only resources we're planning to focus on for the time being. If you feel other Chatbot resources would be helpful, we welcome your PRs.

Additionally, our ability to test the Teams resource is very limited. If you have the capability and find any issues, please let us know!

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/chatbot Issues and PRs that pertain to the chatbot service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_chatbot_slack_channel_configuration
3 participants