Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ECS cluster name validation #38993

Merged
merged 5 commits into from
Sep 24, 2024
+8 −1
Merged

Update ECS cluster name validation #38993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f55c96b
Update ECS cluster name validation
gregops312 Aug 21, 2024
6821570
Removes spurious `.`
gdavison Sep 24, 2024
8235dc8
Updates regexp error message to only refer to values checked by valid…
gdavison Sep 24, 2024
a9524b2
Re-orders regexp for caching
gdavison Sep 24, 2024
e52f676
Adds CHANGELOG entry
gdavison Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changelog/38993.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
```release-note:bug
resource/aws_ecs_cluster: Fix validation error with `name` attribute.
```

```release-note:bug
resource/aws_ecs_cluster_capacity_providers: Fix validation error with `name` attribute.
```
2 changes: 1 addition & 1 deletion internal/service/ecs/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ func validateClusterName(v interface{}, k string) (ws []string, errors []error)
return validation.All(
validation.StringLenBetween(1, 255),
validation.StringMatch(
regexache.MustCompile("[0-9A-Za-z_-]+"),
regexache.MustCompile("^[0-9A-Za-z_-]+$"),
"The cluster name must consist of alphanumerics, hyphens, and underscores."),
)(v, k)
}
Expand Down
Loading