d/aws_api_gateway_api_keys: new data source

[wirkijowski]

Description

New data source to get pre-existing API Key list.

Relations

Resolves #8033

References

https://docs.aws.amazon.com/apigateway/latest/api/API_GetApiKeys.html

Output from Acceptance Testing

% make testacc TESTS=TestAccAPIGatewayAPIKeysDataSource_ PKG=apigateway
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/apigateway/... -v -count 1 -parallel 20 -run='TestAccAPIGatewayAPIKeysDataSource_'  -timeout 360m
=== RUN   TestAccAPIGatewayAPIKeysDataSource_serial
=== PAUSE TestAccAPIGatewayAPIKeysDataSource_serial
=== CONT  TestAccAPIGatewayAPIKeysDataSource_serial
=== RUN   TestAccAPIGatewayAPIKeysDataSource_serial/APIKeys
=== RUN   TestAccAPIGatewayAPIKeysDataSource_serial/APIKeys/basic
=== RUN   TestAccAPIGatewayAPIKeysDataSource_serial/APIKeys/includeValues
=== RUN   TestAccAPIGatewayAPIKeysDataSource_serial/APIKeys/manyKeys
--- PASS: TestAccAPIGatewayAPIKeysDataSource_serial (36.96s)
    --- PASS: TestAccAPIGatewayAPIKeysDataSource_serial/APIKeys (36.96s)
        --- PASS: TestAccAPIGatewayAPIKeysDataSource_serial/APIKeys/basic (12.72s)
        --- PASS: TestAccAPIGatewayAPIKeysDataSource_serial/APIKeys/includeValues (11.83s)
        --- PASS: TestAccAPIGatewayAPIKeysDataSource_serial/APIKeys/manyKeys (12.40s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apigateway 43.194s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @wirkijowski 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[jar-b]

Hi @wirkijowski - Thanks for your submission!

As of 2023-10-20 all net-new data sources are required to use Terraform Plugin Framework. More context is available in this pinned issue and the provider contributor guide.

• Policy Change Notice: Net-new resources/data sources will be required to be based on aws-sdk-go-v2 / terraform-plugin-framework #32917
• https://hashicorp.github.io/terraform-provider-aws/terraform-plugin-development-packages/#which-plugin-version-should-i-use

Maintainers will convert Plugin-SDK based data sources as part of the review process, but if you'd like to do the conversion in the meantime we would greatly appreciate it!

[wirkijowski]

Hi @jar-b - thanks for the feedback. I'm going to convert this.

[wirkijowski]

I've converted from plugin sdk to framweork. Also re-ran acceptance tests:

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/apigateway/... -v -count 1 -parallel 20 -run='TestAccAPIGatewayAPIKeysDataSource_'  -timeout 360m
=== RUN   TestAccAPIGatewayAPIKeysDataSource_serial
=== PAUSE TestAccAPIGatewayAPIKeysDataSource_serial
=== CONT  TestAccAPIGatewayAPIKeysDataSource_serial
=== RUN   TestAccAPIGatewayAPIKeysDataSource_serial/APIKeys
=== RUN   TestAccAPIGatewayAPIKeysDataSource_serial/APIKeys/includeValues
=== RUN   TestAccAPIGatewayAPIKeysDataSource_serial/APIKeys/manyKeys
=== RUN   TestAccAPIGatewayAPIKeysDataSource_serial/APIKeys/basic
--- PASS: TestAccAPIGatewayAPIKeysDataSource_serial (37.38s)
    --- PASS: TestAccAPIGatewayAPIKeysDataSource_serial/APIKeys (37.38s)
        --- PASS: TestAccAPIGatewayAPIKeysDataSource_serial/APIKeys/includeValues (12.67s)
        --- PASS: TestAccAPIGatewayAPIKeysDataSource_serial/APIKeys/manyKeys (12.50s)
        --- PASS: TestAccAPIGatewayAPIKeysDataSource_serial/APIKeys/basic (12.21s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apigateway 43.754s