Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added behavior ref to instance_warmup_period arg desc for aws_ecs_capacity_provider #39436

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Sep 21, 2024

Description

This PR is to add additional information about managed scale-out behavior for the instance_warmup_period argument in the aws_ecs_capacity_provider resource doc. Instead of adding excessive details to the documentation, I decided to keep the argument description consistent with the AWS API doc and link to additional information in the ECS Developer Guide.

Relations

Closes #39420

References

Referenced Control the instances Amazon ECS terminates for context and CreateCapacityProvider for specs.

Output from Acceptance Testing

n/a

@acwwat acwwat requested a review from a team as a code owner September 21, 2024 17:37
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ecs Issues and PRs that pertain to the ecs service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Sep 21, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 23, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit fa5e13e into hashicorp:main Sep 23, 2024
27 checks passed
@github-actions github-actions bot added this to the v5.69.0 milestone Sep 23, 2024
Copy link

This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. service/ecs Issues and PRs that pertain to the ecs service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: Bad description for aws_ecs_capacity_provider.managed_scaling.instance_warmup_period
2 participants