Skip to content

Conversation

@ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Nov 6, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Only attempt XML (un)wrapping in AutoFlEx (added in #44655) if the struct field has an xmlwrapper tag.

Relations

Closes #44951.
Relates #44861.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccCloudFrontContinuousDeploymentPolicy_' PKG=cloudfront ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 b-autoflex-noxmlwrapper 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/cloudfront/... -v -count 1 -parallel 3  -run=TestAccCloudFrontContinuousDeploymentPolicy_ -timeout 360m -vet=off
2025/11/06 14:37:19 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/06 14:37:19 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccCloudFrontContinuousDeploymentPolicy_basic
=== PAUSE TestAccCloudFrontContinuousDeploymentPolicy_basic
=== RUN   TestAccCloudFrontContinuousDeploymentPolicy_disappears
=== PAUSE TestAccCloudFrontContinuousDeploymentPolicy_disappears
=== RUN   TestAccCloudFrontContinuousDeploymentPolicy_trafficConfig
=== PAUSE TestAccCloudFrontContinuousDeploymentPolicy_trafficConfig
=== RUN   TestAccCloudFrontContinuousDeploymentPolicy_domainChange
=== PAUSE TestAccCloudFrontContinuousDeploymentPolicy_domainChange
=== CONT  TestAccCloudFrontContinuousDeploymentPolicy_basic
=== CONT  TestAccCloudFrontContinuousDeploymentPolicy_trafficConfig
=== CONT  TestAccCloudFrontContinuousDeploymentPolicy_domainChange
--- PASS: TestAccCloudFrontContinuousDeploymentPolicy_basic (837.16s)
=== CONT  TestAccCloudFrontContinuousDeploymentPolicy_disappears
--- PASS: TestAccCloudFrontContinuousDeploymentPolicy_trafficConfig (838.38s)
--- PASS: TestAccCloudFrontContinuousDeploymentPolicy_domainChange (1048.72s)
--- PASS: TestAccCloudFrontContinuousDeploymentPolicy_disappears (448.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	1291.745s
% make testacc TESTARGS='-run=TestAccCloudFrontVPCOrigin_' PKG=cloudfront
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 b-autoflex-noxmlwrapper 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/cloudfront/... -v -count 1 -parallel 20  -run=TestAccCloudFrontVPCOrigin_ -timeout 360m -vet=off
2025/11/06 15:02:14 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/06 15:02:14 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccCloudFrontVPCOrigin_basic
=== PAUSE TestAccCloudFrontVPCOrigin_basic
=== RUN   TestAccCloudFrontVPCOrigin_disappears
=== PAUSE TestAccCloudFrontVPCOrigin_disappears
=== RUN   TestAccCloudFrontVPCOrigin_update
=== PAUSE TestAccCloudFrontVPCOrigin_update
=== RUN   TestAccCloudFrontVPCOrigin_tags
=== PAUSE TestAccCloudFrontVPCOrigin_tags
=== CONT  TestAccCloudFrontVPCOrigin_basic
=== CONT  TestAccCloudFrontVPCOrigin_update
=== CONT  TestAccCloudFrontVPCOrigin_disappears
=== CONT  TestAccCloudFrontVPCOrigin_tags
--- PASS: TestAccCloudFrontVPCOrigin_basic (890.78s)
--- PASS: TestAccCloudFrontVPCOrigin_disappears (893.34s)
--- PASS: TestAccCloudFrontVPCOrigin_update (923.58s)
--- PASS: TestAccCloudFrontVPCOrigin_tags (924.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	930.099s

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Nov 6, 2025
@github-actions github-actions bot added the service/cloudfront Issues and PRs that pertain to the cloudfront service. label Nov 6, 2025
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Nov 6, 2025
@ewbankkit ewbankkit marked this pull request as ready for review November 6, 2025 20:02
@ewbankkit ewbankkit requested a review from a team as a code owner November 6, 2025 20:02
jar-b
jar-b previously approved these changes Nov 6, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ewbankkit ewbankkit merged commit 0d43432 into main Nov 6, 2025
54 checks passed
@ewbankkit ewbankkit deleted the b-autoflex-noxmlwrapper branch November 6, 2025 20:38
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.20.0 milestone Nov 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

This functionality has been released in v6.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Addresses a defect in current functionality. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

3 participants