Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4720
Changes proposed in this pull request:
secret
attribute on resource creation, since it's never returned again from the AWS API after creation (despite what the API docs say.)secret
attribute sensitive.branchFilter
without losing the thesecret
.Output from acceptance testing:
NB: To get the
Github
cases to pass, I modified thecodebuild_project
location to point to my fork ofhashibot-test/aws-test.git
. That change is not reflected in the committed code.