Commits on Sep 14, 2018

1. resource/aws_iam_policy: Ensure description is properly read during c… …

   …reation
   
   This resource was previously not following best practices of calling the read function after creation. Now it will read back information from the API, which tangentally fixes the description not being available in the CreatePolicy response.
   
   Changes:
   * Create separate acceptance tests for all arguments
   * Call read function after create and update functions
   * Create `testAccCheckResourceAttrGlobalARN` for checking global ARN attributes
   * Remove extraneous aws/import_aws_iam_policy_test.go
   
   Previously (before code updates):
   
   ```
   === RUN   TestAccAWSIAMPolicy_basic
   --- PASS: TestAccAWSIAMPolicy_basic (10.15s)
   === RUN   TestAccAWSIAMPolicy_description
   --- FAIL: TestAccAWSIAMPolicy_description (5.06s)
       testing.go:527: Step 0 error: Check failed: Check 2/2 error: aws_iam_policy.test: Attribute 'description' expected "description1", got ""
   === RUN   TestAccAWSIAMPolicy_namePrefix
   --- PASS: TestAccAWSIAMPolicy_namePrefix (9.72s)
   === RUN   TestAccAWSIAMPolicy_path
   --- PASS: TestAccAWSIAMPolicy_path (9.85s)
   === RUN   TestAccAWSIAMPolicy_policy
   --- PASS: TestAccAWSIAMPolicy_policy (13.49s)
   ```
   
   Now:
   
   ```
   === RUN   TestAccAWSIAMPolicy_basic
   --- PASS: TestAccAWSIAMPolicy_basic (10.29s)
   === RUN   TestAccAWSIAMPolicy_description
   --- PASS: TestAccAWSIAMPolicy_description (8.00s)
   === RUN   TestAccAWSIAMPolicy_namePrefix
   --- PASS: TestAccAWSIAMPolicy_namePrefix (9.15s)
   === RUN   TestAccAWSIAMPolicy_path
   --- PASS: TestAccAWSIAMPolicy_path (9.25s)
   === RUN   TestAccAWSIAMPolicy_policy
   --- PASS: TestAccAWSIAMPolicy_policy (15.21s)
   ```

   

   bflad committed Sep 14, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for d149602
   • Browse repository at this point

   Copy the full SHA

   d149602 View commit details

   Browse the repository at this point in the history