Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_s3_account_public_access_block #6851

Merged
merged 1 commit into from
Dec 19, 2018

Commits on Dec 14, 2018

  1. New Resource: aws_s3_account_public_access_block

    This implements Public Access Block configuration within the new S3 Control API, which is separate from the existing S3 API. The S3 Control API features the same eventual consistency complexity as the existing S3 API across all operations. The resource and acceptance testing try handling the eventual consistency as best as possible up to a minute.
    
    The resource is named `aws_s3_account_public_access_block` instead of `aws_s3control_public_access_block` to be more operator friendly with respect to it working at the account level.
    
    Changes:
    
    * provider: Implement S3 Control custom endpoint, session, and connection
    * New Resource: aws_s3_account_public_access_block
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSS3Account (169.55s)
        --- PASS: TestAccAWSS3Account/PublicAccessBlock (169.55s)
            --- PASS: TestAccAWSS3Account/PublicAccessBlock/basic (13.01s)
            --- PASS: TestAccAWSS3Account/PublicAccessBlock/disappears (7.95s)
            --- PASS: TestAccAWSS3Account/PublicAccessBlock/AccountId (11.47s)
            --- PASS: TestAccAWSS3Account/PublicAccessBlock/BlockPublicAcls (25.04s)
            --- PASS: TestAccAWSS3Account/PublicAccessBlock/BlockPublicPolicy (25.33s)
            --- PASS: TestAccAWSS3Account/PublicAccessBlock/IgnorePublicAcls (25.33s)
            --- PASS: TestAccAWSS3Account/PublicAccessBlock/RestrictPublicBuckets (26.40s)
    ```
    bflad committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    93c112a View commit details
    Browse the repository at this point in the history