Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple values per one cost filter in aws_budgets_budget resource #9092

Merged
merged 15 commits into from
Jul 27, 2021

Commits on Jul 25, 2021

  1. Handle multiple cost filter values with cost_filter block

    Now, we can specify multiple filter values per a cost filter key like
    
    ```
    resource "aws_budgets_budget" "test" {
      # :
      # (snip)
      # :
    
      cost_filter {
        name = "Region"
        values = [
          "ap-northeast-1",
          "us-east-1",
        ]
      }
    
      cost_filter {
        name = "PurchaseType"
        values = [
          "Spot",
        ]
      }
    
      # :
      # (snip)
      # :
    }
    ```
    
    And we made `cost_filters` deprecated. That should be removed in future
    releases.
    mozamimy authored and ewbankkit committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    7358b88 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fef2731 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8614bbb View commit details
    Browse the repository at this point in the history
  4. Add CHANGELOG entry.

    ewbankkit committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    15f210a View commit details
    Browse the repository at this point in the history
  5. r/aws_budgets_budget_action: Tidy up.

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccAWSBudgetsBudgetAction_'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSBudgetsBudgetAction_ -timeout 180m
    === RUN   TestAccAWSBudgetsBudgetAction_basic
    === PAUSE TestAccAWSBudgetsBudgetAction_basic
    === RUN   TestAccAWSBudgetsBudgetAction_disappears
    === PAUSE TestAccAWSBudgetsBudgetAction_disappears
    === CONT  TestAccAWSBudgetsBudgetAction_basic
    === CONT  TestAccAWSBudgetsBudgetAction_disappears
    --- PASS: TestAccAWSBudgetsBudgetAction_disappears (29.50s)
    --- PASS: TestAccAWSBudgetsBudgetAction_basic (29.58s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	32.689s
    ewbankkit committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    991c8c3 View commit details
    Browse the repository at this point in the history
  6. r/aws_budgets_budget: Use internal finder package.

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccAWSBudgetsBudget_basic'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSBudgetsBudget_basic -timeout 180m
    === RUN   TestAccAWSBudgetsBudget_basic
    === PAUSE TestAccAWSBudgetsBudget_basic
    === CONT  TestAccAWSBudgetsBudget_basic
    --- PASS: TestAccAWSBudgetsBudget_basic (23.28s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.567s
    ewbankkit committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    2c7b23c View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. r/aws_budgets_budget,r/aws_budgets_budget_action: Correct service nam…

    …e in ARN.
    
    Acceptance test output:
    % make testacc TESTARGS='-run=TestAccAWSBudgetsBudget_basic\|TestAccAWSBudgetsBudget_disappears\|TestAccAWSBudgetsBudgetAction_'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSBudgetsBudget_basic\|TestAccAWSBudgetsBudget_disappears\|TestAccAWSBudgetsBudgetAction_ -timeout 180m
    === RUN   TestAccAWSBudgetsBudgetAction_basic
    === PAUSE TestAccAWSBudgetsBudgetAction_basic
    === RUN   TestAccAWSBudgetsBudgetAction_disappears
    === PAUSE TestAccAWSBudgetsBudgetAction_disappears
    === RUN   TestAccAWSBudgetsBudget_basic
    === PAUSE TestAccAWSBudgetsBudget_basic
    === RUN   TestAccAWSBudgetsBudget_disappears
    === PAUSE TestAccAWSBudgetsBudget_disappears
    === RUN   TestAccAWSBudgetsBudget_basicish
    === PAUSE TestAccAWSBudgetsBudget_basicish
    === CONT  TestAccAWSBudgetsBudgetAction_basic
    === CONT  TestAccAWSBudgetsBudget_disappears
    === CONT  TestAccAWSBudgetsBudget_basicish
    === CONT  TestAccAWSBudgetsBudget_basic
    === CONT  TestAccAWSBudgetsBudgetAction_disappears
    --- PASS: TestAccAWSBudgetsBudget_disappears (10.17s)
    --- PASS: TestAccAWSBudgetsBudget_basic (13.11s)
    --- PASS: TestAccAWSBudgetsBudget_basicish (24.14s)
    --- PASS: TestAccAWSBudgetsBudgetAction_disappears (24.38s)
    --- PASS: TestAccAWSBudgetsBudgetAction_basic (58.92s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	62.207s
    ewbankkit committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    63ffe35 View commit details
    Browse the repository at this point in the history
  2. r/aws_budgets_budget: 'time_period_start' is optional (hashicorp#19803).

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccAWSBudgetsBudget_basic'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSBudgetsBudget_basic -timeout 180m
    === RUN   TestAccAWSBudgetsBudget_basic
    === PAUSE TestAccAWSBudgetsBudget_basic
    === RUN   TestAccAWSBudgetsBudget_basicish
    === PAUSE TestAccAWSBudgetsBudget_basicish
    === CONT  TestAccAWSBudgetsBudget_basic
    === CONT  TestAccAWSBudgetsBudget_basicish
    --- PASS: TestAccAWSBudgetsBudget_basic (17.08s)
    --- PASS: TestAccAWSBudgetsBudget_basicish (27.29s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	30.688s
    ewbankkit committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    875772d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c08db33 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    08f204d View commit details
    Browse the repository at this point in the history
  5. r/aws_budget_budget: Add 'TestAccAWSBudgetsBudget_CostTypes'.

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccAWSBudgetsBudget_CostTypes'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSBudgetsBudget_CostTypes -timeout 180m
    === RUN   TestAccAWSBudgetsBudget_CostTypes
    === PAUSE TestAccAWSBudgetsBudget_CostTypes
    === CONT  TestAccAWSBudgetsBudget_CostTypes
    --- PASS: TestAccAWSBudgetsBudget_CostTypes (20.96s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	24.217s
    ewbankkit committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    9cee6ef View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. r/aws_budgets_budget: Add 'TestAccAWSBudgetsBudget_Notifications'.

    Acceptance test output:
    
    % make testacc TESTARGS='-run=TestAccAWSBudgetsBudget_Notifications'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSBudgetsBudget_Notifications -timeout 180m
    === RUN   TestAccAWSBudgetsBudget_Notifications
    === PAUSE TestAccAWSBudgetsBudget_Notifications
    === CONT  TestAccAWSBudgetsBudget_Notifications
    --- PASS: TestAccAWSBudgetsBudget_Notifications (27.42s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	30.688s
    ewbankkit committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    13bb671 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    88c52a6 View commit details
    Browse the repository at this point in the history
  3. Run 'go mod tidy'.

    ewbankkit committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    6cfd26b View commit details
    Browse the repository at this point in the history
  4. Fix terrafmt errors.

    ewbankkit committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    174d265 View commit details
    Browse the repository at this point in the history