Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final retries after timeouts for ECS resources #9704

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Final retries after timeouts for ECS resources #9704

merged 1 commit into from
Aug 12, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES: 
* resource/aws_ecs_cluster: Final retries after timeouts reading and deleting ECS cluster
* resource/aws_ecs_service: Final retries after timeouts creating, updating, and deleting ECS service

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSEcsCluster"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSEcsCluster -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSEcsCluster_basic
=== PAUSE TestAccAWSEcsCluster_basic
=== RUN   TestAccAWSEcsCluster_disappears
=== PAUSE TestAccAWSEcsCluster_disappears
=== RUN   TestAccAWSEcsCluster_Tags
=== PAUSE TestAccAWSEcsCluster_Tags
=== CONT  TestAccAWSEcsCluster_basic
=== CONT  TestAccAWSEcsCluster_Tags
=== CONT  TestAccAWSEcsCluster_disappears
--- PASS: TestAccAWSEcsCluster_disappears (19.66s)
--- PASS: TestAccAWSEcsCluster_basic (27.09s)
--- PASS: TestAccAWSEcsCluster_Tags (61.43s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       62.544s

make testacc TESTARGS="-run=TestAccAWSEcsService"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSEcsService -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSEcsServiceDataSource_basic
=== PAUSE TestAccAWSEcsServiceDataSource_basic
=== RUN   TestAccAWSEcsService_withARN
=== PAUSE TestAccAWSEcsService_withARN
=== RUN   TestAccAWSEcsService_basicImport
=== PAUSE TestAccAWSEcsService_basicImport
=== RUN   TestAccAWSEcsService_disappears
=== PAUSE TestAccAWSEcsService_disappears
=== RUN   TestAccAWSEcsService_withUnnormalizedPlacementStrategy
=== PAUSE TestAccAWSEcsService_withUnnormalizedPlacementStrategy
=== RUN   TestAccAWSEcsService_withFamilyAndRevision
=== PAUSE TestAccAWSEcsService_withFamilyAndRevision
=== RUN   TestAccAWSEcsService_withRenamedCluster
=== PAUSE TestAccAWSEcsService_withRenamedCluster
=== RUN   TestAccAWSEcsService_healthCheckGracePeriodSeconds
=== PAUSE TestAccAWSEcsService_healthCheckGracePeriodSeconds
=== RUN   TestAccAWSEcsService_withIamRole
=== PAUSE TestAccAWSEcsService_withIamRole
=== RUN   TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy
=== PAUSE TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy
=== RUN   TestAccAWSEcsService_withDeploymentValues
=== PAUSE TestAccAWSEcsService_withDeploymentValues
=== RUN   TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred
=== PAUSE TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred
=== RUN   TestAccAWSEcsService_withLbChanges
=== PAUSE TestAccAWSEcsService_withLbChanges
=== RUN   TestAccAWSEcsService_withEcsClusterName
=== PAUSE TestAccAWSEcsService_withEcsClusterName
=== RUN   TestAccAWSEcsService_withAlb
=== PAUSE TestAccAWSEcsService_withAlb
=== RUN   TestAccAWSEcsService_withMultipleTargetGroups
=== PAUSE TestAccAWSEcsService_withMultipleTargetGroups
=== RUN   TestAccAWSEcsService_withPlacementStrategy
=== PAUSE TestAccAWSEcsService_withPlacementStrategy
=== RUN   TestAccAWSEcsService_withPlacementConstraints
=== PAUSE TestAccAWSEcsService_withPlacementConstraints
=== RUN   TestAccAWSEcsService_withPlacementConstraints_emptyExpression
=== PAUSE TestAccAWSEcsService_withPlacementConstraints_emptyExpression
=== RUN   TestAccAWSEcsService_withLaunchTypeFargate
=== PAUSE TestAccAWSEcsService_withLaunchTypeFargate
=== RUN   TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion
=== PAUSE TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion
=== RUN   TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration
=== PAUSE TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration
=== RUN   TestAccAWSEcsService_withDaemonSchedulingStrategy
=== PAUSE TestAccAWSEcsService_withDaemonSchedulingStrategy
=== RUN   TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum
=== PAUSE TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum
=== RUN   TestAccAWSEcsService_withReplicaSchedulingStrategy
=== PAUSE TestAccAWSEcsService_withReplicaSchedulingStrategy
=== RUN   TestAccAWSEcsService_withServiceRegistries
=== PAUSE TestAccAWSEcsService_withServiceRegistries
=== RUN   TestAccAWSEcsService_withServiceRegistries_container
=== PAUSE TestAccAWSEcsService_withServiceRegistries_container
=== RUN   TestAccAWSEcsService_Tags
=== PAUSE TestAccAWSEcsService_Tags
=== RUN   TestAccAWSEcsService_ManagedTags
=== PAUSE TestAccAWSEcsService_ManagedTags
=== RUN   TestAccAWSEcsService_PropagateTags
=== PAUSE TestAccAWSEcsService_PropagateTags
=== CONT  TestAccAWSEcsServiceDataSource_basic
=== CONT  TestAccAWSEcsService_withServiceRegistries_container
=== CONT  TestAccAWSEcsService_PropagateTags
=== CONT  TestAccAWSEcsService_withServiceRegistries
=== CONT  TestAccAWSEcsService_withReplicaSchedulingStrategy
=== CONT  TestAccAWSEcsService_Tags
=== CONT  TestAccAWSEcsService_ManagedTags
=== CONT  TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum
=== CONT  TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred
=== CONT  TestAccAWSEcsService_withDeploymentValues
=== CONT  TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy
=== CONT  TestAccAWSEcsService_withIamRole
=== CONT  TestAccAWSEcsService_healthCheckGracePeriodSeconds
=== CONT  TestAccAWSEcsService_withRenamedCluster
=== CONT  TestAccAWSEcsService_withFamilyAndRevision
=== CONT  TestAccAWSEcsService_withUnnormalizedPlacementStrategy
=== CONT  TestAccAWSEcsService_disappears
=== CONT  TestAccAWSEcsService_basicImport
=== CONT  TestAccAWSEcsService_withLbChanges
=== CONT  TestAccAWSEcsService_withARN
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (60.18s)
=== CONT  TestAccAWSEcsService_withDaemonSchedulingStrategy
--- PASS: TestAccAWSEcsService_disappears (67.61s)
=== CONT  TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (70.91s)
=== CONT  TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion
--- PASS: TestAccAWSEcsService_ManagedTags (71.62s)
=== CONT  TestAccAWSEcsService_withLaunchTypeFargate
--- PASS: TestAccAWSEcsService_withDeploymentValues (71.82s)
=== CONT  TestAccAWSEcsService_withPlacementConstraints_emptyExpression
--- PASS: TestAccAWSEcsService_basicImport (78.05s)
=== CONT  TestAccAWSEcsService_withPlacementConstraints
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (78.35s)
=== CONT  TestAccAWSEcsService_withPlacementStrategy
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (81.90s)
=== CONT  TestAccAWSEcsService_withMultipleTargetGroups
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (82.56s)
=== CONT  TestAccAWSEcsService_withAlb
--- PASS: TestAccAWSEcsServiceDataSource_basic (86.78s)
=== CONT  TestAccAWSEcsService_withEcsClusterName
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (47.10s)
--- PASS: TestAccAWSEcsService_Tags (111.94s)
--- PASS: TestAccAWSEcsService_withARN (111.96s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (80.82s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (153.40s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (70.18s)
--- PASS: TestAccAWSEcsService_withIamRole (161.99s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (87.09s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (179.90s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (183.67s)
--- PASS: TestAccAWSEcsService_PropagateTags (195.14s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (159.72s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (204.64s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (215.92s)
--- PASS: TestAccAWSEcsService_withLbChanges (288.00s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (302.17s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (267.86s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (355.35s)
--- PASS: TestAccAWSEcsService_withAlb (313.97s)
--- PASS: TestAccAWSEcsService_withMultipleTargetGroups (317.14s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       400.197s

@ryndaniels ryndaniels requested a review from a team August 9, 2019 15:33
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ecs Issues and PRs that pertain to the ecs service. labels Aug 9, 2019
@ryndaniels ryndaniels added the bug Addresses a defect in current functionality. label Aug 9, 2019
@ryndaniels ryndaniels added this to the v2.24.0 milestone Aug 9, 2019
bflad
bflad approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSEcsCluster_disappears (12.23s)
--- PASS: TestAccAWSEcsCluster_basic (15.63s)
--- PASS: TestAccAWSEcsCluster_Tags (25.35s)
--- PASS: TestAccAWSEcsServiceDataSource_basic (52.08s)
--- PASS: TestAccAWSEcsService_disappears (57.35s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (45.83s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (60.60s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (65.74s)
--- PASS: TestAccAWSEcsService_withARN (66.68s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (52.44s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (70.73s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (70.70s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (71.32s)
--- PASS: TestAccAWSEcsService_basicImport (72.99s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (91.85s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (42.58s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (77.95s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (53.62s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (52.32s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (52.83s)
--- PASS: TestAccAWSEcsService_ManagedTags (52.58s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (89.70s)
--- PASS: TestAccAWSEcsService_Tags (72.94s)
--- PASS: TestAccAWSEcsService_withIamRole (204.85s)
--- PASS: TestAccAWSEcsService_PropagateTags (143.45s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (221.79s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (161.73s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (161.89s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (260.18s)
--- PASS: TestAccAWSEcsService_withMultipleTargetGroups (280.67s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (283.49s)
--- PASS: TestAccAWSEcsService_withLbChanges (287.32s)
--- PASS: TestAccAWSEcsService_withAlb (289.07s)

@ryndaniels ryndaniels merged commit 9303676 into master Aug 12, 2019
@ryndaniels ryndaniels deleted the rfd-retry-ecs branch August 12, 2019 12:06
@ghost
Copy link

ghost commented Aug 15, 2019

This has been released in version 2.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
bug Addresses a defect in current functionality. service/ecs Issues and PRs that pertain to the ecs service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryndaniels @bflad