Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_appmesh_route: Add support for HTTP-header-based routing and route priorities #9964

Closed
wants to merge 10 commits into from

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 3, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9802.
Replaces #9803.

Relevant commits have been cherry picked from #9468.

Release note for CHANGELOG:

resource/aws_appmesh_route: Add `priority` and `header` attributes to support route priorities and HTTP-header-based routing

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmesh'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSAppmesh -timeout 120m
=== RUN   TestAccAWSAppmesh
=== RUN   TestAccAWSAppmesh/Mesh
=== RUN   TestAccAWSAppmesh/Mesh/basic
=== RUN   TestAccAWSAppmesh/Mesh/egressFilter
=== RUN   TestAccAWSAppmesh/Mesh/tags
=== RUN   TestAccAWSAppmesh/Route
=== RUN   TestAccAWSAppmesh/Route/httpHeader
=== RUN   TestAccAWSAppmesh/Route/httpRoute
=== RUN   TestAccAWSAppmesh/Route/tcpRoute
=== RUN   TestAccAWSAppmesh/Route/routePriority
=== RUN   TestAccAWSAppmesh/Route/tags
=== RUN   TestAccAWSAppmesh/VirtualNode
=== RUN   TestAccAWSAppmesh/VirtualNode/basic
=== RUN   TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh/VirtualNode/logging
=== RUN   TestAccAWSAppmesh/VirtualNode/tags
=== RUN   TestAccAWSAppmesh/VirtualRouter
=== RUN   TestAccAWSAppmesh/VirtualRouter/basic
=== RUN   TestAccAWSAppmesh/VirtualRouter/tags
=== RUN   TestAccAWSAppmesh/VirtualService
=== RUN   TestAccAWSAppmesh/VirtualService/tags
=== RUN   TestAccAWSAppmesh/VirtualService/virtualNode
=== RUN   TestAccAWSAppmesh/VirtualService/virtualRouter
--- PASS: TestAccAWSAppmesh (811.85s)
    --- PASS: TestAccAWSAppmesh/Mesh (101.56s)
        --- PASS: TestAccAWSAppmesh/Mesh/basic (19.32s)
        --- PASS: TestAccAWSAppmesh/Mesh/egressFilter (38.74s)
        --- PASS: TestAccAWSAppmesh/Mesh/tags (43.51s)
    --- PASS: TestAccAWSAppmesh/Route (206.73s)
        --- PASS: TestAccAWSAppmesh/Route/httpHeader (41.00s)
        --- PASS: TestAccAWSAppmesh/Route/httpRoute (41.44s)
        --- PASS: TestAccAWSAppmesh/Route/tcpRoute (40.93s)
        --- PASS: TestAccAWSAppmesh/Route/routePriority (41.19s)
        --- PASS: TestAccAWSAppmesh/Route/tags (42.16s)
    --- PASS: TestAccAWSAppmesh/VirtualNode (280.35s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/basic (22.52s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/cloudMapServiceDiscovery (122.72s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/listenerHealthChecks (49.25s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/logging (35.40s)
        --- PASS: TestAccAWSAppmesh/VirtualNode/tags (50.45s)
    --- PASS: TestAccAWSAppmesh/VirtualRouter (86.63s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/basic (35.42s)
        --- PASS: TestAccAWSAppmesh/VirtualRouter/tags (51.21s)
    --- PASS: TestAccAWSAppmesh/VirtualService (136.58s)
        --- PASS: TestAccAWSAppmesh/VirtualService/tags (57.21s)
        --- PASS: TestAccAWSAppmesh/VirtualService/virtualNode (40.82s)
        --- PASS: TestAccAWSAppmesh/VirtualService/virtualRouter (38.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	811.930s

@ewbankkit ewbankkit requested a review from a team September 3, 2019 12:20
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/appmesh Issues and PRs that pertain to the appmesh service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 3, 2019
@ewbankkit ewbankkit changed the title [WIP] r/aws_appmesh_route: Add support for HTTP-header-based routing and route priorities r/aws_appmesh_route: Add support for HTTP-header-based routing and route priorities Sep 3, 2019
@ewbankkit
Copy link
Contributor Author

ewbankkit commented Sep 3, 2019

The errors when running the labeler action

##[error]HttpError: Resource not accessible by integration
##[error]Resource not accessible by integration
##[error]Node run failed with exit code 1

are the same as seen in other PRs, e.g. #8259 (comment).
My guess is that since both AppMesh and RAM have entries in .github/PULL_REQUEST_LABELS.yml then the token used by the labeler action doesn't have permissions to call addLabels.

@aeschright
Copy link
Contributor

@ewbankkit
Copy link
Contributor Author

It seems that there is a known issue with the current GitHub labeler action and PRs on forks: actions/labeler#12.

@ewbankkit
Copy link
Contributor Author

Closing in favor of #10075.

@ewbankkit ewbankkit closed this Oct 6, 2019
@ewbankkit ewbankkit deleted the issue-9802-MkII branch October 6, 2019 22:22
@ghost
Copy link

ghost commented Nov 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/appmesh Issues and PRs that pertain to the appmesh service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS App Mesh HTTP-header-based routing and route priorities
2 participants