new resource azurerm_elastic_san_volume
#24802
Conversation
There was a problem hiding this comment.
Hi @teowa,
Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍
BTW, please also involve the test results.
| Timeout: 5 * time.Minute, | ||
| Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error { | ||
| if oldVal, newVal := metadata.ResourceDiff.GetChange("size_in_gib"); newVal.(int) < oldVal.(int) { | ||
| return fmt.Errorf("new size_in_gib should be greater than the existing one") |
There was a problem hiding this comment.
shall we add a testcase for this validation?
There was a problem hiding this comment.
This is included in update test
|
There was a problem hiding this comment.
Have a test failure:
------- Stdout: -------
=== RUN TestAccElasticSANVolume_complete
=== PAUSE TestAccElasticSANVolume_complete
=== CONT TestAccElasticSANVolume_complete
testcase.go:113: Step 1/2 error: Error running apply: exit status 1
Error: creating Volume (Subscription: "*******"
Resource Group Name: "acctestrg-esvg-240229223355576575"
Elastic San Name: "acctestes-4pwq0"
Volume Group Name: "acctestesvg-4pwq0"
Volume Name: "acctestesv-4pwq0"): polling after Create: polling failed: the Azure API returned the following error:
Status: "InternalServerError"
Code: ""
Message: "Internal server error."
Activity Id: ""
---
API Response:
----[start]----
{"status":"Failed","error":{"code":"InternalServerError","message":"Internal server error."}}
-----[end]-----
with azurerm_elastic_san_volume.test,
on terraform_plugin_test.tf line 70, in resource "azurerm_elastic_san_volume" "test":
70: resource "azurerm_elastic_san_volume" "test" {
creating Volume (Subscription: "*******"
Resource Group Name: "acctestrg-esvg-240229223355576575"
Elastic San Name: "acctestes-4pwq0"
Volume Group Name: "acctestesvg-4pwq0"
Volume Name: "acctestesv-4pwq0"): polling after Create: polling failed: the
Azure API returned the following error:
Status: "InternalServerError"
Code: ""
Message: "Internal server error."
Activity Id: ""
---
API Response:
----[start]----
{"status":"Failed","error":{"code":"InternalServerError","message":"Internal
server error."}}
-----[end]-----
--- FAIL: TestAccElasticSANVolume_complete (184.96s)
FAIL
|
Hi, the service team should have the backend fixed, the the test can pass now: |
|
|
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
reference: