fix nil panic when SecurityProfile is nil

[yangzuo0621]

As not all clusters have property SecurityProfile, when SecurityProfile is nil, it will panic with nil pointer.

[stephybun]

Thanks for this PR @yangzuo0621.

I have a request to change where we nil check SecurityProfile. If you can take a look at that when we can give this another look and get this merged.

Thanks!

[stephybun]

We nil check SecurityProfile at multiple points in the Read where we set security property values into state.

For consistency could we actually update flattenCustomCaTrustCerts to do the nil check instead of doing a general one here

Suggested change

	if props.SecurityProfile == nil {
	props.SecurityProfile = &managedclusters.ManagedClusterSecurityProfile{}
	}
	customCaTrustCertList := flattenCustomCaTrustCerts(props.SecurityProfile.CustomCATrustCertificates)
	customCaTrustCertList := flattenCustomCaTrustCerts(props.SecurityProfile)

flattenCustomCaTrustCerts would then become

func flattenCustomCaTrustCerts(input *managedclusters.ManagedClusterSecurityProfile) []interface{} {
	if input == nil || input.CustomCATrustCertificates == nil {
		return make([]interface{}, 0)
	}

	customCaTrustCertInterface := make([]interface{}, len(*input.CustomCATrustCertificates))

	for index, value := range *input.CustomCATrustCertificates {
		customCaTrustCertInterface[index] = value
	}

	return customCaTrustCertInterface
}

[github-actions]

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

[stephybun]

Since it's been over a month I looked into finalising this PR for you but stumbled onto some other issues with the custom_ca_trust_certificates_base64 property. As a result I ended up opening a PR to make the changes to the nil check as well as fix the behaviour in the provider for this property.

I'm going to close this PR in favour of #23737. Thanks again for your contribution.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.