monitor_activity_log_alert: add location attribute

[andaryjo]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

This PR adds the location attribute to the monitor_activity_log_alert resource, allowing users to specify the location the resource should get deployed in. Previously Terraform always would set the location global.

Note that Azure currently only supports following regions: 'global,westeurope,northeurope'. Using a different one will fail during the apply. I think it would be better to let the API do the validation this instead of hardcoding supported locations in the provider, but let me know how you guys usually handle this.

This is not a breaking change, the default location continues to be global. If users do not change their Terraform code, Terraform won't detect any changes for existing activity alert rules.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_monitor_activity_log_alert - support for the location property

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Closes #25375

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[katbyte]

Thanks for the pr @andaryjo - could we add the propertly to a new/the complete test to ensure it works correctly? thanks!

[andaryjo]

I basically copied the test setup from the monitor_action_group resource. Let me know if that works for you. Can't really test them since I currently don't have an Azure test environment available.

[stephybun]

Thanks for this @andaryjo. Would you mind addressing the suggestions left in-line? Once those are fixed up this should be good to go.

[stephybun]

Thanks @andaryjo LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.