Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_monitor_smart_detector_alert_rule - Normalize action_group.ids #25559

Merged
merged 2 commits into from
Apr 11, 2024
Merged

azurerm_monitor_smart_detector_alert_rule - Normalize action_group.ids #25559

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b72a21
`azurerm_monitor_smart_detector_alert_rule` - Normalize `action_group…
magodo Apr 10, 2024
fbc31b9
Update internal/services/monitor/monitor_smart_detector_alert_rule_re…
magodo Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions internal/services/monitor/monitor_smart_detector_alert_rule_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
commonValidate "github.com/hashicorp/terraform-provider-azurerm/helpers/validate"
"github.com/hashicorp/terraform-provider-azurerm/internal/clients"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/monitor/migration"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/monitor/parse"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/monitor/validate"
"github.com/hashicorp/terraform-provider-azurerm/internal/tf/pluginsdk"
"github.com/hashicorp/terraform-provider-azurerm/internal/tf/set"
Expand Down Expand Up @@ -251,7 +252,11 @@ func resourceMonitorSmartDetectorAlertRuleRead(d *pluginsdk.ResourceData, meta i
}
d.Set("throttling_duration", throttlingDuration)

if err := d.Set("action_group", flattenMonitorSmartDetectorAlertRuleActionGroup(&props.ActionGroups)); err != nil {
actionGroup, err := flattenMonitorSmartDetectorAlertRuleActionGroup(&props.ActionGroups)
if err != nil {
return fmt.Errorf("flatten `action_group`: %+v", err)
}
if err := d.Set("action_group", actionGroup); err != nil {
return fmt.Errorf("setting `action_group`: %+v", err)
}
}
Expand Down Expand Up @@ -288,9 +293,9 @@ func expandMonitorSmartDetectorAlertRuleActionGroup(input []interface{}) *smartd
}
}

func flattenMonitorSmartDetectorAlertRuleActionGroup(input *smartdetectoralertrules.ActionGroupsInformation) []interface{} {
func flattenMonitorSmartDetectorAlertRuleActionGroup(input *smartdetectoralertrules.ActionGroupsInformation) ([]interface{}, error) {
if input == nil {
return []interface{}{}
return []interface{}{}, nil
}

var customEmailSubject, CustomWebhookPayload string
Expand All @@ -301,11 +306,20 @@ func flattenMonitorSmartDetectorAlertRuleActionGroup(input *smartdetectoralertru
CustomWebhookPayload = *input.CustomWebhookPayload
}

groupIds := make([]string, 0)
for _, idRaw := range input.GroupIds {
id, err := parse.ActionGroupIDInsensitively(idRaw)
if err != nil {
return nil, fmt.Errorf("parsing %s: %v", idRaw, err)
}
groupIds = append(groupIds, id.ID())
}

return []interface{}{
map[string]interface{}{
"ids": input.GroupIds,
"ids": groupIds,
"email_subject": customEmailSubject,
"webhook_payload": CustomWebhookPayload,
},
}
}, nil
}
Loading