Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Container App Jobs resource to 2024-02-02-preview #26994

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Dionmm
Copy link
Contributor

@Dionmm Dionmm commented Aug 9, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

All tests passed.
The TestAccContainerAppJob_complete* tests apppear to be flaky, passing on some runs and failing on others during the post-test destroy step.

make acctests SERVICE=containerapps TESTARGS='-run=TestAccContainerAppJob -p=2' TESTTIMEOUT='80m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/containerapps -run=TestAccContainerAppJob -p=2 -timeout 80m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccContainerAppJob_basic
=== PAUSE TestAccContainerAppJob_basic
=== RUN   TestAccContainerAppJob_withWorkloadProfile
=== PAUSE TestAccContainerAppJob_withWorkloadProfile
=== RUN   TestAccContainerAppJob_withWorkloadProfileUpdate
=== PAUSE TestAccContainerAppJob_withWorkloadProfileUpdate
=== RUN   TestAccContainerAppJob_withSystemAssignedIdentity
=== PAUSE TestAccContainerAppJob_withSystemAssignedIdentity
=== RUN   TestAccContainerAppJob_withUserAssignedIdentity
=== PAUSE TestAccContainerAppJob_withUserAssignedIdentity
=== RUN   TestAccContainerAppJob_withSystemAndUserAssignedIdentity
=== PAUSE TestAccContainerAppJob_withSystemAndUserAssignedIdentity
=== RUN   TestAccContainerAppJob_withIdentityUpdate
=== PAUSE TestAccContainerAppJob_withIdentityUpdate
=== RUN   TestAccContainerAppJob_eventTrigger
=== PAUSE TestAccContainerAppJob_eventTrigger
=== RUN   TestAccContainerAppJob_manualTrigger
=== PAUSE TestAccContainerAppJob_manualTrigger
=== RUN   TestAccContainerAppJob_scheduleTrigger
=== PAUSE TestAccContainerAppJob_scheduleTrigger
=== RUN   TestAccContainerAppJob_complete
=== PAUSE TestAccContainerAppJob_complete
=== RUN   TestAccContainerAppJob_completeDeprecated
=== PAUSE TestAccContainerAppJob_completeDeprecated
=== RUN   TestAccContainerAppJob_completeUpdate
=== PAUSE TestAccContainerAppJob_completeUpdate
=== RUN   TestAccContainerAppJob_withKeyVaultSecret
=== PAUSE TestAccContainerAppJob_withKeyVaultSecret
=== RUN   TestAccContainerAppJob_withKeyVaultSecretVersioningUpdate
=== PAUSE TestAccContainerAppJob_withKeyVaultSecretVersioningUpdate
=== RUN   TestAccContainerAppJob_withKeyVaultSecretIdentityUpdate
=== PAUSE TestAccContainerAppJob_withKeyVaultSecretIdentityUpdate
=== CONT  TestAccContainerAppJob_basic
=== CONT  TestAccContainerAppJob_scheduleTrigger
=== CONT  TestAccContainerAppJob_withSystemAndUserAssignedIdentity
=== CONT  TestAccContainerAppJob_withUserAssignedIdentity
=== CONT  TestAccContainerAppJob_manualTrigger
=== CONT  TestAccContainerAppJob_withSystemAssignedIdentity
=== CONT  TestAccContainerAppJob_eventTrigger
=== CONT  TestAccContainerAppJob_completeUpdate
=== CONT  TestAccContainerAppJob_withKeyVaultSecretIdentityUpdate
=== CONT  TestAccContainerAppJob_withKeyVaultSecretVersioningUpdate
=== CONT  TestAccContainerAppJob_withKeyVaultSecret
=== CONT  TestAccContainerAppJob_withWorkloadProfileUpdate
--- PASS: TestAccContainerAppJob_eventTrigger (589.96s)
=== CONT  TestAccContainerAppJob_complete
--- PASS: TestAccContainerAppJob_scheduleTrigger (601.55s)
=== CONT  TestAccContainerAppJob_completeDeprecated
--- PASS: TestAccContainerAppJob_withSystemAssignedIdentity (607.11s)
=== CONT  TestAccContainerAppJob_withWorkloadProfile
--- PASS: TestAccContainerAppJob_withSystemAndUserAssignedIdentity (610.17s)
=== CONT  TestAccContainerAppJob_withIdentityUpdate
--- PASS: TestAccContainerAppJob_basic (615.60s)
--- PASS: TestAccContainerAppJob_withUserAssignedIdentity (681.86s)
--- PASS: TestAccContainerAppJob_completeUpdate (686.53s)
=== NAME  TestAccContainerAppJob_complete
    testcase.go:130: Error running post-test destroy, there may be dangling resources: exit status 1

        Error: deleting Storage (Subscription: "XX"
        Resource Group Name: "acctestRG-CAEnv-240809221335165593"
        Managed Environment Name: "acctest-CAEnv240809221335165593"
        Storage Name: "testacc-caes-240809221335165593"): unexpected status 400 (400 Bad Request) with error: ManagedEnvironmentStorageDeleteInUse: Cannot delete Managed environment storage 'testacc-caes-240809221335165593' because it's still in use.

        deleting Storage (Subscription: "XX"
        Resource Group Name: "acctestRG-CAEnv-240809221335165593"
        Managed Environment Name: "acctest-CAEnv240809221335165593"
        Storage Name: "testacc-caes-240809221335165593"): unexpected status 400 (400
        Bad Request) with error: ManagedEnvironmentStorageDeleteInUse: Cannot delete
        Managed environment storage 'testacc-caes-240809221335165593' because it's
        still in use.
--- FAIL: TestAccContainerAppJob_complete (141.87s)
--- PASS: TestAccContainerAppJob_withKeyVaultSecret (863.66s)
--- PASS: TestAccContainerAppJob_manualTrigger (965.12s)
--- PASS: TestAccContainerAppJob_withKeyVaultSecretIdentityUpdate (1018.81s)
--- PASS: TestAccContainerAppJob_completeDeprecated (592.79s)
--- PASS: TestAccContainerAppJob_withKeyVaultSecretVersioningUpdate (1226.71s)
--- PASS: TestAccContainerAppJob_withIdentityUpdate (658.95s)
--- PASS: TestAccContainerAppJob_withWorkloadProfile (1587.22s)
--- PASS: TestAccContainerAppJob_withWorkloadProfileUpdate (2974.42s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_container_app_job - support for API version 2024-02-02-preview

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Forms part of a group of PRs for #26570

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍚

@katbyte katbyte merged commit a1e3da2 into hashicorp:main Sep 20, 2024
1 check passed
@github-actions github-actions bot added this to the v4.3.0 milestone Sep 20, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants