Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace hashibot with github actions #9270

Merged
merged 3 commits into from
Jun 2, 2021
Merged

replace hashibot with github actions #9270

merged 3 commits into from
Jun 2, 2021

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jun 1, 2021

Fixes #9136

@ghost ghost added the size/l label Jun 1, 2021
@megan07 megan07 requested review from rileykarson and bflad June 1, 2021 16:50
@github-actions github-actions bot requested a review from ScottSuarez June 1, 2021 16:50
@@ -0,0 +1,16 @@
name: Issue Comment Created Triage
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will just remove stale and waiting-reply if a maintainer adds them at creation time, right? Is it possible a maintainer would do that on first file intentionally / do we expect it to happen unintentionally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's when a comment is created on the issue that we'll remove stale and waiting-reply, does that answer your question?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yup, that makes more sense!

issue_comment_triage:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my bad in the migration plan, I don't think this is necessary for this workflow 👍

Suggested change
- uses: actions/checkout@v2

runs-on: ubuntu-latest
name: Label the PR size
steps:
- uses: codelytv/pr-size-labeler@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream enhancement to allow specifying the size labels is still pending: CodelyTV/pr-size-labeler#26

Up to you folks whether this is worth skipping this migration for now (I will ensure there is a solution before decommissioning) or if it is worth renaming the repository size/* labels with lowercase to match this action after merging this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have no preference, so i'll rename the labels to lowercase. thanks!

@ScottSuarez ScottSuarez removed their request for review June 2, 2021 18:31
@megan07 megan07 merged commit 26a738a into master Jun 2, 2021
@github-actions
Copy link

github-actions bot commented Jul 3, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Hashibot Functionality with GitHub Actions
3 participants