-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace hashibot with github actions #9270
Conversation
@@ -0,0 +1,16 @@ | |||
name: Issue Comment Created Triage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will just remove stale
and waiting-reply
if a maintainer adds them at creation time, right? Is it possible a maintainer would do that on first file intentionally / do we expect it to happen unintentionally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it's when a comment is created on the issue that we'll remove stale
and waiting-reply
, does that answer your question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yup, that makes more sense!
issue_comment_triage: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my bad in the migration plan, I don't think this is necessary for this workflow 👍
- uses: actions/checkout@v2 |
runs-on: ubuntu-latest | ||
name: Label the PR size | ||
steps: | ||
- uses: codelytv/pr-size-labeler@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream enhancement to allow specifying the size labels is still pending: CodelyTV/pr-size-labeler#26
Up to you folks whether this is worth skipping this migration for now (I will ensure there is a solution before decommissioning) or if it is worth renaming the repository size/*
labels with lowercase to match this action after merging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have no preference, so i'll rename the labels to lowercase. thanks!
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Fixes #9136