Deprecating body and replacing with response_body
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendbennett
changed the title
body and replacing with response_body
bflad
approved these changes
May 31, 2022
internal/provider/data_source.go
Outdated
Comment on lines
57
to
59
| Elem: &schema.Schema{ | ||
| Type: schema.TypeString, | ||
| }, |
There was a problem hiding this comment.
schema.TypeString does not have elements like a list, map, or set would. 👍
Suggested change
| Elem: &schema.Schema{ | |
| Type: schema.TypeString, | |
| }, |
There was a problem hiding this comment.
Have removed Elem from url, body and response_body as all are TypeString.
orgads
added a commit
to orgads/terraform-provider-http-full
that referenced
this pull request
Sep 5, 2022
* Deprecating body and replacing with response_body * Updating docs and CHANGELOG.md * Removing unneeded Elem from Schema (cherry picked from hashicorp/terraform-provider-http#137)
orgads
added a commit
to orgads/terraform-provider-http-full
that referenced
this pull request
Sep 5, 2022
* Deprecating body and replacing with response_body * Updating docs and CHANGELOG.md * Removing unneeded Elem from Schema (cherry picked from hashicorp/terraform-provider-http#137) Fixes salrashid123#10.
orgads
added a commit
to orgads/terraform-provider-http-full
that referenced
this pull request
Sep 6, 2022
* Deprecating body and replacing with response_body * Updating docs and CHANGELOG.md Cherry picked from hashicorp/terraform-provider-http#137. Fixes salrashid123#10.
orgads
added a commit
to orgads/terraform-provider-http-full
that referenced
this pull request
Sep 6, 2022
Cherry picked from hashicorp/terraform-provider-http#137. Fixes salrashid123#10.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to align attribute naming,
bodyis being deprecated and replaced byresponse_body.