Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate body attribute #166

Merged
merged 3 commits into from
Jul 27, 2022
Merged

Reinstate body attribute #166

merged 3 commits into from
Jul 27, 2022

Conversation

bendbennett
Copy link
Contributor

This PR reinstates the deprecated body attribute that was removed as part of v3.0.0 changes.

@bendbennett bendbennett requested a review from a team as a code owner July 27, 2022 18:25
@bendbennett bendbennett merged commit 27c6c29 into main Jul 27, 2022
@bendbennett bendbennett deleted the reinstate-body branch July 27, 2022 18:42
@akhileshnayak
Copy link

Curious why this was reinstated and whether it will be removed again in the future?

@SudoSpartanDan
Copy link

@akhileshnayak I was wondering the same thing. Just jumped through hoops to get a workaround built into our module for this only to have it added back in....

@akhileshnayak
Copy link

akhileshnayak commented Jul 27, 2022

Yeah - if there isn't a huge cost to keeping it around given it's an alias to another field on a provider that's not too large maybe it's ok to just leave it in there?

@lisenet
Copy link

lisenet commented Jul 28, 2022

What's next guys?

v3.0.2 - deprecated body has been removed (again?)
v3.0.1 - deprecated body has been reinstated
v3.0.0 - deprecated body has been removed
v2.2.0 - deprecate body

@n1ngu
Copy link

n1ngu commented Aug 17, 2022

My guess is that the motivation to reinstate the body attribute stems from #165 and the linked core issues.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants