provider/aws: Allow to change the DynamoDB Endpoint

[phstc]

Hi

This PR allows us to change the DynamoDB Endpoint, which super useful to run "migrations" against dynamodb-local.

With that, we can use the same scripts we use in production (AWS DynamoDB), in development (dynamodb-local).

The way I'm using it:

cd tf/local

ls
table1.tf
table2.tf
config.tf

terraform plan
terraform apply

In the folder local besides the table definitions, I have also a config.tf with:

provider "aws" {
    access_key = "123"
    secret_key = "123"
    region = "us-east-1"
    dynamodb_endpoint = "http://localhost:8000"
}

which changes the DynamoDB Endpoint.

I've intentionally set access and secret to 123, as we don't need those to connect to dynamodb-local.

Any code feedback would be more than appreciated 🍻

Fix #2763.

[phstc]

I didn't like this duplication of configs, but we can't set Endpoint for all other connections. I've also tried to copy awsConfig, but go didn't like it:

awsDynamoDBConfig := *awsConfig
awsDynamoDBConfig.Endpoint = c.DynamoDBEndpoint

Any ideas?

[phinze]

I think this is fine for now - the duplication is super local. If we get more duplication here we can investigate cleanup options. 👌

[phinze]

Is "" equivalent to "use upstream default" here?

[phstc]

@phinze that's correct based on their docs: https://github.com/aws/aws-sdk-go/blob/67dc9f948602be9f85cb640f89b0adec994ccbda/aws/config.go#L49-L55 and I've also confirmed that on my local tests.

But I can remove the Default: "" above and make it more explicit:

awsDynamoDBConfig := &aws.Config{
    Credentials: creds,
    Region:      c.Region,
    MaxRetries:  c.MaxRetries,
}

if c.DynamoDBEndpoint != nil {
    awsDynamoDBConfig.Endpoint = c.DynamoDBEndpoint
}

wdyt?

[phinze]

Thanks for this, @phstc - one inline question, and think you could add the attribute to the provider docs too?

[phstc]

@phinze provider docs ^^^ updated 🍻

[phstc]

@phinze not sure why the tests are failing make test is passing locally and the changes I did after the last successfully build were only on the docs.

[catsby]

@phstc there have been upstream changes to the config struct used by AWS. A simple merge from master and changing your config like so should do the trick:

awsDynamoDBConfig := &aws.Config{
  Credentials: creds,
  Region:      aws.String(c.Region),
  MaxRetries:  aws.Int(c.MaxRetries),
  Endpoint:    aws.String(c.DynamoDBEndpoint),
}

[phstc]

@catsby thanks! all set then:

All checks have passed

[phstc]

?

[catsby]

Thanks @phstc !

[phstc]

🤘

@catsby is there a new release on the schedule? or a mailing list to subscribe to get release updates? I will wait for a new release to update my work colleagues to start using terraform with dynamodb-local.

[catsby]

is there a new release on the schedule

I think next week, I'll double check

a mailing list to subscribe to get release updates

There is a mailing list here:

• https://groups.google.com/group/terraform-tool

I don't know that we've been very diligent about announcing there. We typically tweet the announcement here https://twitter.com/hashicorp , e.g. https://twitter.com/hashicorp/status/623250629247520768

That said, we probably should announce on the list...

[phstc]

@catsby thanks! You got a new follower 😄

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.