-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: allow using global variables in suite-level variable definitions #34699
Conversation
b76481b
to
ae5f847
Compare
ae5f847
to
ef36fc0
Compare
ef36fc0
to
383d010
Compare
383d010
to
7ae7a20
Compare
9896221
to
42c478c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we do need to know about the type I don't know what I intended to say here.
61f5aa0
to
df3ee21
Compare
17d9205
to
e573680
Compare
ed2a331
to
ea0856b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a couple of small things around naming and tidying up.
Generally a "TestSuite" refers to all the test files currently being executed not just the current test file, so there's a couple of places where I think we should change names and comments to reflect that.
Thanks!
Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>
Co-authored-by: Liam Cervante <liam.cervante@hashicorp.com>
Just a note on the changelog entry. I usually start with the full command, so something like:
Or something like that. |
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This allows practitioners to define variables in
.tfvar
files, environment variables, CLI flags and use them in the definition of suit-level variables in the top-level variables block.Fixes #34534
Fixes #34538
Target Release
1.8.x
Draft CHANGELOG entry
ENHANCEMENTS