aws/provider: Resolves DefaultOS and ConfigurationManager conflict

[u2mejc]

This resolves, allot: #5569 #5905 #5958 #6221 (and anything else that would otherwise be blocked by stack creation failing).

[stack72]

Hey @u2mejc

This fails due to go vet issues - do you think any of the tests should be updated here with this func change?

P.

[u2mejc]

Hi Paul, I don't believe so, it doesn't really add any new features?

Looking at Travis, it says format issue, but it's passing on my machine?

$ gofmt -w builtin/providers/aws/resource_aws_opsworks_stack.go
$ echo $?
0

[stack72]

Very weird - this passes locally for me too :)

Running the tests, I can see the following output:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSOpsworksStack' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSOpsworksStack -timeout 120m
=== RUN   TestAccAWSOpsworksStackNoVpc
--- PASS: TestAccAWSOpsworksStackNoVpc (20.24s)
=== RUN   TestAccAWSOpsworksStackVpc
--- PASS: TestAccAWSOpsworksStackVpc (61.79s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    82.041s

This LGTM! Thanks so much for all the work here

Paul

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.