VPCZoneIdentifier cannot be empty

[joshuaspence]

I have a module that I use for creating AWS autoscaling groups. I have the following variable defined within my module:

variable "vpc_zone_identifier" {
  type        = "string"
  default     = ""
  description = "A comma-separated list of subnet IDs to launch resources in."
}

I then have the following Terraform code:

resource "aws_autoscaling_group" "autoscaling_group" {
  name     = "${var.name}"
  max_size = "${var.max_size}"
  min_size = "${var.min_size}"

  availability_zones        = ["${split(",", var.availability_zones)}"]
  launch_configuration      = "${aws_launch_configuration.launch_configuration.name}"
  health_check_grace_period = "${var.health_check_grace_period}"
  health_check_type         = "${var.health_check_type}"
  desired_capacity          = "${var.desired_capacity}"
  load_balancers            = ["${compact(split(",", var.load_balancers))}"]
  vpc_zone_identifier       = ["${compact(split(",", var.vpc_zone_identifier))}"]
  termination_policies      = ["${compact(split(",", var.termination_policies))}"]

  wait_for_capacity_timeout = "${var.wait_for_capacity_timeout}"
  min_elb_capacity          = "${var.min_elb_capacity}"
  wait_for_elb_capacity     = "${var.wait_for_elb_capacity}"
}

If I try to use this code to create an ASG that is //not// within a VPC. I get an error from the AWS API:

* aws_autoscaling_group.autoscaling_group: Error updating Autoscaling group: InvalidParameter: 1 validation errors:
- field too short, minimum length 1: VPCZoneIdentifier

The following change seems to make things work again:

-  vpc_zone_identifier       = ["${compact(split(",", var.vpc_zone_identifier))}"]
+  vpc_zone_identifier       = ["${split(",", var.vpc_zone_identifier)}"]

[stack72]

Hi @joshuaspence

I believe this will be fine now that we can pass lists rather than CSV based variables

Thoughts?

Paul

[stack72]

Closing this - not heard back in 28 days. Please do let me know if this is still an issue :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.