Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endpoint_auto_confirms and confirmation_timeout_in_minutes for sqs endpoints #6652

Closed
scheffield opened this issue May 13, 2016 · 2 comments
Closed

Comments

@scheffield
Copy link

Hi,

I recently upgraded to version 0.6.16. Now I get changes for my sns subscriptions which look as follows:

~ aws_sns_topic_subscription.foo-subscription
    confirmation_timeout_in_minutes: "" => "1"
    endpoint_auto_confirms:          "" => "false"

The protocol I'm subscribing to is sqs. From what I understand (reading the documentation: http://docs.aws.amazon.com/sns/latest/dg/SendMessageToHttp.html#SendMessageToHttp.prepare) auto confirm makes only sense for http/https endpoints. Applying the changes affects the terraform state but not the actual subscription. I recon the change was introduced by #4711

Please find my actual configuration and other infos below.

Terraform Version

Terraform v0.6.16

Affected Resource(s)

  • aws_sns_topic_subscription

Terraform Configuration Files

resource "aws_sns_topic" "foo" {
  name = "foo-topic"
}

resource "aws_sns_topic_subscription" "foo-subscription" {
  topic_arn = "arn:aws:sns:us-east-1:************:foo"
  protocol = "sqs"
  endpoint = "arn:aws:sqs:us-east-1************:foo-queue"
  raw_message_delivery = true
  depends_on = ["aws_sns_topic.foo"]
}
@stack72
Copy link
Contributor

stack72 commented Aug 24, 2016

Hi @scheffield

My apologies this slipped through the net here and has taken so long to get back to you. In a situation like this, we usually take care of a state migration so that the user still gets the same behaviour

In this case, the changes themselves were not breaking changes - as you said, they changed the state only and not the subscription

We will endeavour to make sure that users do not see this type of behaviour in the future. This will only have affected those people who upgraded to 0.6.16 onwards

Paul

@stack72 stack72 added the waiting-response An issue/pull request is waiting for a response from the community label Aug 24, 2016
@mitchellh mitchellh removed the waiting-response An issue/pull request is waiting for a response from the community label Dec 1, 2016
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants