Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always quote identifiers when encoding HCL #12245

Merged
merged 2 commits into from
Feb 25, 2017
Merged

Always quote identifiers when encoding HCL #12245

merged 2 commits into from
Feb 25, 2017

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Feb 24, 2017

HCL identifiers may need to be quoted, so always quote them to be safe.

fixes #11977

HCL identifiers may need to be quoted, so always quote them to be safe.
Change the expected outputs in the Push tests to match the quotes map
keys.
Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once tests pass LGTM. This is true.

@jbardin
Copy link
Member Author

jbardin commented Feb 24, 2017

ha, the failure is fixed in another PR ;) re-running tests until they pass for now

@jbardin jbardin merged commit 6e9e610 into master Feb 25, 2017
@jbardin jbardin deleted the jbardin/hcl-encode branch February 25, 2017 00:00
@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform push fails where plan doesn't
2 participants