From 94ef573b662df831dce0469bdbea50bf0146bdc8 Mon Sep 17 00:00:00 2001 From: David Radcliffe Date: Fri, 17 Jul 2015 17:04:22 -0400 Subject: [PATCH 1/2] DNSimple does not support changing a record domain or type --- builtin/providers/dnsimple/resource_dnsimple_record.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin/providers/dnsimple/resource_dnsimple_record.go b/builtin/providers/dnsimple/resource_dnsimple_record.go index 644876cd8dac..82002ab83047 100644 --- a/builtin/providers/dnsimple/resource_dnsimple_record.go +++ b/builtin/providers/dnsimple/resource_dnsimple_record.go @@ -19,6 +19,7 @@ func resourceDNSimpleRecord() *schema.Resource { "domain": &schema.Schema{ Type: schema.TypeString, Required: true, + ForceNew: true, }, "domain_id": &schema.Schema{ @@ -39,6 +40,7 @@ func resourceDNSimpleRecord() *schema.Resource { "type": &schema.Schema{ Type: schema.TypeString, Required: true, + ForceNew: true, }, "value": &schema.Schema{ From f1cc9fafb3550e304f0982a6424c6b905c186179 Mon Sep 17 00:00:00 2001 From: David Radcliffe Date: Fri, 17 Jul 2015 17:07:01 -0400 Subject: [PATCH 2/2] =?UTF-8?q?=E2=80=9CDNS=20Simple=E2=80=9D=20should=20b?= =?UTF-8?q?e=20=E2=80=9CDNSimple=E2=80=9D?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../providers/dnsimple/resource_dnsimple_record.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/builtin/providers/dnsimple/resource_dnsimple_record.go b/builtin/providers/dnsimple/resource_dnsimple_record.go index 82002ab83047..a16a41f35f0f 100644 --- a/builtin/providers/dnsimple/resource_dnsimple_record.go +++ b/builtin/providers/dnsimple/resource_dnsimple_record.go @@ -76,12 +76,12 @@ func resourceDNSimpleRecordCreate(d *schema.ResourceData, meta interface{}) erro newRecord.Ttl = ttl.(string) } - log.Printf("[DEBUG] DNS Simple Record create configuration: %#v", newRecord) + log.Printf("[DEBUG] DNSimple Record create configuration: %#v", newRecord) recId, err := client.CreateRecord(d.Get("domain").(string), newRecord) if err != nil { - return fmt.Errorf("Failed to create DNS Simple Record: %s", err) + return fmt.Errorf("Failed to create DNSimple Record: %s", err) } d.SetId(recId) @@ -95,7 +95,7 @@ func resourceDNSimpleRecordRead(d *schema.ResourceData, meta interface{}) error rec, err := client.RetrieveRecord(d.Get("domain").(string), d.Id()) if err != nil { - return fmt.Errorf("Couldn't find DNS Simple Record: %s", err) + return fmt.Errorf("Couldn't find DNSimple Record: %s", err) } d.Set("domain_id", rec.StringDomainId()) @@ -135,11 +135,11 @@ func resourceDNSimpleRecordUpdate(d *schema.ResourceData, meta interface{}) erro updateRecord.Ttl = attr.(string) } - log.Printf("[DEBUG] DNS Simple Record update configuration: %#v", updateRecord) + log.Printf("[DEBUG] DNSimple Record update configuration: %#v", updateRecord) _, err := client.UpdateRecord(d.Get("domain").(string), d.Id(), updateRecord) if err != nil { - return fmt.Errorf("Failed to update DNS Simple Record: %s", err) + return fmt.Errorf("Failed to update DNSimple Record: %s", err) } return resourceDNSimpleRecordRead(d, meta) @@ -148,12 +148,12 @@ func resourceDNSimpleRecordUpdate(d *schema.ResourceData, meta interface{}) erro func resourceDNSimpleRecordDelete(d *schema.ResourceData, meta interface{}) error { client := meta.(*dnsimple.Client) - log.Printf("[INFO] Deleting DNS Simple Record: %s, %s", d.Get("domain").(string), d.Id()) + log.Printf("[INFO] Deleting DNSimple Record: %s, %s", d.Get("domain").(string), d.Id()) err := client.DestroyRecord(d.Get("domain").(string), d.Id()) if err != nil { - return fmt.Errorf("Error deleting DNS Simple Record: %s", err) + return fmt.Errorf("Error deleting DNSimple Record: %s", err) } return nil