Backport of provider meta: don't return providers with invalid names into v1.9 #35849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
backport/liamcervante/35835/cheaply-main-beagle
branch
from
886159d
to
df5a122
Compare
liamcervante
approved these changes
Oct 14, 2024
liamcervante
deleted the
backport/liamcervante/35835/cheaply-main-beagle
branch
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #35842 to be assessed for backporting due to the inclusion of the label 1.9-backport.
The below text is copied from the body of the original PR.
This PR updates the parsing of the
provider_metablocks so that providers with invalid names aren't returned. This prevents a crash that occurs later when the names are parsed, and doesn't affect behaviour otherwise as the diagnostic explaining the error is still returned.Fixes #35835
Target Release
1.9.x
Draft CHANGELOG entry
BUG FIXES
provider_metablocks with invalid names.Overview of commits