Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Small stacks feedback into v1.9 #35897

Merged

Conversation

github-actions[bot]
Copy link
Contributor

Backport

This PR is auto-generated from #35896 to be assessed for backporting due to the inclusion of the label 1.9-backport.

The below text is copied from the body of the original PR.


Following up with stacks feedback from Keran and feedback from Daniel on good auto_approve catches .


Overview of commits

@rkoron007 rkoron007 marked this pull request as ready for review October 23, 2024 22:11
Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same!

@rkoron007 rkoron007 merged commit 627ce9d into v1.9 Oct 23, 2024
6 checks passed
@rkoron007 rkoron007 deleted the backport/RK/fix-stacks-docs-feedback/recently-firm-llama branch October 23, 2024 22:32
Copy link
Contributor Author

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor Author

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant