Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: check preconditions and postconditions for ephemeral resources #35920

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Oct 29, 2024

Complete custom condition checks for ephemeral resources. These essentially work the same as they do for managed resources, however an ephemeral resource will continue "run" after a failed postcondition, to give the provider a chance to eventually call Close if needed.

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.


Does this also impact the check blocks?

I actually don't know if they work already but if they do, it may be worth adding a test case.

Either way we can leave that for a separate PR.

internal/terraform/node_module_variable.go Outdated Show resolved Hide resolved
Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>
@jbardin jbardin merged commit 9a90202 into main Oct 29, 2024
6 checks passed
@jbardin jbardin deleted the jbardin/ephemeral-conditions branch October 29, 2024 17:29
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants