issensitive must return unknown for unknown args without sensitive
#36012
+18
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform attempts to track marks as accurately as possible, but unknown values may not always have the same marks as they will when they become known. This is most easily seen with functions, which are allowed to return an unknown value when faced with any unknown arguments, while they are also allowed to manipulate the marks on the values as they see fit. This results in situations where the marks simply cannot be known. Terraform generally takes the stance that if an unknown has a mark, it will remain in the final value, but the absence of a mark is not indicative of the absence of any marks in the final value.
Comment on lines
+74
to
+77
| case v.HasMark(marks.Sensitive): | ||
| return cty.True, nil | ||
| case !v.IsKnown(): | ||
| return cty.UnknownVal(cty.Bool), nil |
There was a problem hiding this comment.
It can't lose marks going from unknown to known? Do we want to switch these case statements around?
There was a problem hiding this comment.
Whoops, I didn't read the PR description 😅
liamcervante
approved these changes
Nov 15, 2024
Comment on lines
+74
to
+77
| case v.HasMark(marks.Sensitive): | ||
| return cty.True, nil | ||
| case !v.IsKnown(): | ||
| return cty.UnknownVal(cty.Bool), nil |
There was a problem hiding this comment.
Whoops, I didn't read the PR description 😅
jbardin
added
the
1.10-backport
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform attempts to track marks as accurately as possible, but unknown values may not always have the same marks as they will when they become known. This is most easily seen with functions, which are allowed to return an unknown value when faced with any unknown arguments, while they are also allowed to manipulate the marks on the values as they see fit. This results in situations where the marks simply cannot be known.
Terraform generally takes the stance that if an unknown has a mark, it will remain in the final value, but the absence of a mark is not indicative of the absence of any marks in the final value. That appears to be something we can continue to maintain throughout the codebase, so given that axiom I'm going to codify it here by only changing the
issensitiveresults for unknown, unmarked values, but allowing unknown+sensitive values to returntrue.