Support lists validation in resources schema definition #3641
Conversation
|
@jsoriano any chance you could throw together a test case for this? @phinze, @mitchellh this could use your 👀 |
ELB doesn't support multiple health checks, terraform allowed to define them, but it used the first one without any warning. After this change it will fail.
jsoriano
force-pushed
the
validate-lists
branch
from
e20e643 to
14529b5
Compare
|
@josephholsten I have added some tests for lists and sets validation. |
|
Hi @jsoriano I am sorry that this has taken so long to get back to - since this PR was opened, we added some new helper schema additions that will help here. One of them is MaxItems - that will remove the need for this ValidationFunc in this PR I am going to close this out - thanks for the work you have put in there. We really do appreciate it! Please let me know if you have any other questions Thanks Paul |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Supports lists validation in resources schema definition.
The motivation of this change is to check that there are not multiple definitions of health checks in AWS ELBs.
Currently terraform allows to define several health checks, but an ELB can only have one health check and only the first one is used, ignoring the rest without any warning. A developer can think that all the health checks are being configured, but only the first one is created at the end.