-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAULT-5280 add telemetry annotations for agent sidecar #413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I only had one suggestion for the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor nits to address, then 👍
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
vault.hashicorp.com/agent-telemetry
which defines the telemetry configuration for the agent sidecar. All parameters linked above are currently supported.vault.hashicorp.com/agent-telemetry-<key>: "<value>"
An example which configures prometheus telemetry on the agent sidecar for an application:
..which results in the following configuration stanza being added to the sidecar environment via rendering the environment:
Note to Reviewers: docs PR hashicorp/vault#18681