Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-5280 add telemetry annotations for agent sidecar #413

Merged
merged 7 commits into from
Jan 18, 2023

Conversation

kschoche
Copy link
Contributor

@kschoche kschoche commented Jan 11, 2023

  • Adds a new annotation for vault.hashicorp.com/agent-telemetry which defines the telemetry configuration for the agent sidecar. All parameters linked above are currently supported.
  • The annotation behaves similarly to vault.hashicorp.com/auth-config in that you specify an annotation via vault.hashicorp.com/agent-telemetry-<key>: "<value>"

An example which configures prometheus telemetry on the agent sidecar for an application:

annotations:
	"vault.hashicorp.com/agent-telemetry-prometheus_retention_time": "30s",
	"vault.hashicorp.com/agent-telemetry-disable_hostname":          "true",

..which results in the following configuration stanza being added to the sidecar environment via rendering the environment:

telemetry {
  prometheus_retention_time = "30s"
  disable_hostname = true
}

Note to Reviewers: docs PR hashicorp/vault#18681

@kschoche kschoche added the enhancement New feature or request label Jan 11, 2023
@kschoche kschoche self-assigned this Jan 11, 2023
@kschoche kschoche marked this pull request as ready for review January 13, 2023 15:52
Copy link

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kschoche kschoche requested a review from tomhjp January 18, 2023 16:05
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I only had one suggestion for the tests.

agent-inject/agent/config_test.go Outdated Show resolved Hide resolved
@kschoche kschoche requested a review from benashz January 18, 2023 21:27
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor nits to address, then 👍

agent-inject/agent/config_test.go Outdated Show resolved Hide resolved
agent-inject/agent/config_test.go Outdated Show resolved Hide resolved
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants