UI: Parse OpenAPI response correctly if schema includes $ref #14508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ui/app/services/path-help.js
Outdated
| let props = {}; | ||
| const schema = pathInfo?.post?.requestBody?.content['application/json'].schema; | ||
| if (schema.$ref) { | ||
| // $ref will be shaped like `#/component/schema/MyResponseType |
There was a problem hiding this comment.
super small comment but components and schemas are plural in the $ref
"$ref": "#/components/schemas/KvLookupRequest"
...but does that affect your mapping?
There was a problem hiding this comment.
oh nope! it doesn't, since you're using reduce and setting the keys on 212
There was a problem hiding this comment.
no, but I should probably be accurate in my comment 😄
hellobontempo
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds UI support for the changes in #14217
Before this change, the UI was broken where we try to generate the form based on OpenAPI:
After, the form is rendered as expected:
