Raft: use a larger initial heartbeat/election timeout #15042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lier=1 and don't yet have the newer raft lib allowing us to reload heartbeat/election timeout config.
…t multiplier (3x), and making use of the new raft lib's ability to reload heartbeat/election timeout config after coming up.
ncabatoff
changed the title
raskchanky
reviewed
Apr 27, 2022
HridoyRoy
approved these changes
Apr 27, 2022
|
|
||
| leader := state.Leader | ||
| deadline := time.Now().Add(2 * time.Minute) | ||
| for time.Now().Before(deadline) { |
There was a problem hiding this comment.
I'm not sure I understand how this test circles back to the addition and use of the reloadable config. Could you clarify a little on this please?
There was a problem hiding this comment.
This test was failing originally (see first commit). So it's basically just validating that restarting (or sealing/unsealing) a node doesn't provoke new elections, by virtue of the change to the initial timeout. We're using a perf multiplier of 5, and the default timeout is 1s, so by sleeping for 10s between seal/unseal we're hoping to trigger (or not, now that we have the fix) an election if the bug is still present.
raskchanky
reviewed
Apr 27, 2022
…onfig can trigger elections, and if all nodes trigger an election at once that can delay things, causing test failures due to timeouts.
…o as high as 48s if you include the random factor, timeouts elsewhere must be increased.
raskchanky
reviewed
Apr 28, 2022
raskchanky
approved these changes
Apr 28, 2022
ncabatoff
added a commit
that referenced
this pull request
Apr 29, 2022
ncabatoff
added a commit
that referenced
this pull request
Apr 29, 2022
ncabatoff
added a commit
that referenced
this pull request
Apr 29, 2022
ncabatoff
added a commit
that referenced
this pull request
May 6, 2022
ncabatoff
added a commit
that referenced
this pull request
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we leave initialTimeoutMultiplier=1 and don't yet have the newer raft lib allowing us to reload heartbeat/election timeout config.