-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agent: add disable_idle_connections configurable #15986
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
reviewed
Jun 14, 2022
swenson
reviewed
Jun 15, 2022
jasonodonnell
changed the title
agent: add disable_keep_alives configurable
agent: add disable_idle_connections configurable
Jun 16, 2022
swenson
reviewed
Jun 16, 2022
swenson
approved these changes
Jun 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
calvn
approved these changes
Jun 16, 2022
jasonodonnell
added a commit
that referenced
this pull request
Jun 21, 2022
* agent: add disable_keep_alives configurable * Add empty test * Add website doc * Change to disable_idle_connections * Update tests and doc * Add note about env * Changelog * Change to slice * Remove unused disable keep alive methods * Add invalid value test
jasonodonnell
added a commit
that referenced
this pull request
Jun 21, 2022
* agent: add disable_keep_alives configurable * Add empty test * Add website doc * Change to disable_idle_connections * Update tests and doc * Add note about env * Changelog * Change to slice * Remove unused disable keep alive methods * Add invalid value test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A commit to go-retryablehttp changed the default behavior of closing every successful request to instead keeping the connection open. This was done to allow users of the package to utilize TCP keep alives. This resulted in a large number of connections being left open for 90 seconds by Vault Agent 1.6.0+.
This PR adds a new configurable,
disable_idle_connections
, which takes a string list to disable idle connections for various features in Vault Agent (auto-auth
,caching
andtemplating
).A small example can be found here: